Date: Sun, 16 Feb 2003 12:46:41 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: David Schultz <dschultz@uclink.Berkeley.EDU> Cc: Alfred Perlstein <alfred@FreeBSD.org>, Sam Leffler <sam@errno.com>, <src-committers@FreeBSD.org>, <cvs-src@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <20030216122520.A20233-100000@gamplex.bde.org> In-Reply-To: <20030214214748.GA2520@HAL9000.homeunix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 14 Feb 2003, David Schultz wrote:
> Thus spake Alfred Perlstein <alfred@FreeBSD.ORG>:
> > * Sam Leffler <sam@errno.com> [030214 07:15] wrote:
> > > More like "gratuitous style".
> >
> > More like when looking at the file in otder to fix other things I was so
> > turned off by it that it offended me and for that reason needed fixing.
>
> A single extra space at the end of a line offends you? Some of
It offends me if I look at the lines using something that is affected
by the spaces.
> the ``style problems'' fixed by this commit aren't even in
> style(9). However, the following IS in style(9):
Most are. The patch fixes the following style bugs:
(1) white space at EOL: 3 instances
(2) long line: 4 instances
(3) missing blank line after (null) declarations: 8 instances
(4) missing blank space after keyword: 1 instance
I only really care about (2) and (4). The others mainly get in the
way of automatic fixing. indent(1) only understands (1) and (4).
style(9) documents (3) and (4) explicitly and (1) and (2) by example.
(4) is bogus IMO but it is Normally followed in BSD sources.
> Stylistic changes (including whitespace changes) are hard
> on the source repository and are to be avoided without
> good reason.
>
> People don't seem to understand that violating this principle
> makes it very hard to maintain local patches. If the file is
I know a bit about this problem since I have 100000 lines of local
patches (including 28000 lines in kern which have to be merged by
hand for almost every change). However, I like alfred's changes.
Even kern is becoming very ugly due to inconsistent styles.
Formatting changes are very easy to merge compared with semantic
changes unless they are done globally.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030216122520.A20233-100000>