From nobody Thu Mar 17 01:09:43 2022 X-Original-To: rc@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 743C41A2D031 for ; Thu, 17 Mar 2022 01:09:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KJpvr1WLYz3Kn3 for ; Thu, 17 Mar 2022 01:09:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C9C2520D34 for ; Thu, 17 Mar 2022 01:09:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22H19hqa034915 for ; Thu, 17 Mar 2022 01:09:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22H19h39034914 for rc@FreeBSD.org; Thu, 17 Mar 2022 01:09:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: rc@FreeBSD.org Subject: [Bug 238301] [PATCH] handle encrypted swap in dumpon rc.d script Date: Thu, 17 Mar 2022 01:09:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rc@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion related to /etc/rc.d design and implementation List-Archive: https://lists.freebsd.org/archives/freebsd-rc List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-rc@freebsd.org X-BeenThere: freebsd-rc@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647479384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pYwR2ramWhJkpTj/U9fZ9x8BugTwuo2XxvVF6NJe6I0=; b=eSxTMlgebGOVR33gj3UuWCYoOy0EO7rIynHIjkpFf65XH7dwpGFuY/AGb7flhl6GoLckUf +VAPFvioztKQ3BupWMTC549YEcu8UaosNYZzV/lukUBsgx2U4/muMRnA/P3fUz+80EM73l v0SQH5dpZZki8oF62L5deLhsfNkS1H4BjVOMC4TPq/GSKgwk1ZTpdws6qZHCu0ORKmVqOg AsZEbtoXvhxhQOgobtYUFxN4lZobhSDTfrRbaPUCLKM5gV2WWreaoktgOWszZMiV5QhwEk IprVunKIRhdAxpz0wX6VsvZ5It6b0OYOEjeHS0z+gtg6nLAwyzuBxAUPBHPNqQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647479384; a=rsa-sha256; cv=none; b=N1US7o6HOrK2zCtHmV6Pvu0efMNZLt1e3m4V41cIZFE5SB8CvSIppHvwEA41qYTUrtGq42 W1qcfP3QS+8s5I49wQLRyDmvSe1KtXHEyugkbLdcVrnQ9LWzfHCTocrbS/RmiuzIjADNrY 6jKZH4HUZcHk2XVynr/UWQDPmlHec6mYd6iFWVQsNvBa/Zc2D8+g7sQaMXxVvzJ7PMTeFw fGG18GrFk+owasdXSoFi2Zmq9Gt6yNHl95yw7uk2l8Lk65CmxS6iee2SaaD8RSHuC+BiXX R8EO1uhUorAi8mmsNDMg5rOI43QKNrFAlctNYGaYmV0saHYnVQ4XgawmSKf8Ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238301 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2a719333189d9637c0997c4256e5a42a3= 8505c1e commit 2a719333189d9637c0997c4256e5a42a38505c1e Author: Ed Maste AuthorDate: 2022-03-07 19:17:01 +0000 Commit: Ed Maste CommitDate: 2022-03-17 01:08:56 +0000 dumpon: use underlying device if encrypted swap is in use /etc/rc.d/dumpon runs before /etc/rc.d/swap. When encrypted swap is in use the .eli or .bde device will not exist at the time dumpon runs. Even if this is addressed it does not make sense to dump core to encrypted swap, as the encryption key will not be available after reboot rendering the dump useless. Thus, for the case that dumpdev=3DA= UTO and encrypted swap is in use, strip the extension and use the underlying device. Emit a warning if we are using the underlying device and the user has n= ot configured dump encryption, so that the user knows that the will not be encrypted. PR: 238301 Reported by: Ivan Rozhuk Reviewed by: jilles MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34474 (cherry picked from commit 67e751f167c98d02f85eb38401e3e6388db09ac1) libexec/rc/rc.d/dumpon | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=