From owner-svn-src-head@freebsd.org Thu Jun 14 03:32:15 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3E02101982A for ; Thu, 14 Jun 2018 03:32:15 +0000 (UTC) (envelope-from juli@northcloak.com) Received: from mail-qt0-x236.google.com (mail-qt0-x236.google.com [IPv6:2607:f8b0:400d:c0d::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 428E76F06F for ; Thu, 14 Jun 2018 03:32:15 +0000 (UTC) (envelope-from juli@northcloak.com) Received: by mail-qt0-x236.google.com with SMTP id i18-v6so4523736qtp.12 for ; Wed, 13 Jun 2018 20:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=northcloak-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zDFFhV57mCzzdG7W8GYUX4sDL4NC77kEwIAVuVeuRns=; b=s03KencNFiOOM7Zm6cIUMHD1sfYuQJAwKQVVrsR5ssRWu8r3PQ9E6PBofaMYUCghVQ Ww2f1qRp9txdN2jFTxYTz67wJj05i/JlAp63FjEPYWTdBAgUNsy6+uTXKia05ZSsnLNw ublNdwpaGtNv+AJ497asoPjTrdFUx5/cO4DMwK6k0CzhI3vKmUKea37Nhg+APH7OF5VS Yx2WH1HLJPeyBRe3BbH/d2TVIFJufVgQYrteI3+2osKfUNkNcjGB/tZyglQQaredkXEr +CcVa6KtNIxtXYiePetPSVv8znWfGTf8DEKB/ZXnG2diFV6YMyxaWMsFNmq3kMiW64WK g7ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zDFFhV57mCzzdG7W8GYUX4sDL4NC77kEwIAVuVeuRns=; b=ruTk7mZYlusxqEfqKtlPZwEZmmF6npMZkpHR4pQFW2HbDrcs/G7ShxudMuMHmAjbAz Kisz54Vek6YyoQ86+TifkpKLIgKGH9YXEtcrBEHLmtmHbLFnCLrXXqyesZ0yN2Zg+ArH /oHVCRXHFjs4RQL9KXLDR5W6jtuP6NBT5BgDv2xdOK6VI0Uetf5QNRIhj7QnRIQMyPf8 vdPLKhEhqCdYBDhaAo1fbB3S6qK7kOR7iGYBvyz9qniotGA10Ze3Z2b7OrkcmlT7OHfZ eIjoBlfmEXBg+E/r+nhyytFnE0dEDIN0f9Ys+adzbhV54/ofdPYCcxXo0lFLdzfoPx1J G5Kw== X-Gm-Message-State: APt69E1rlJ9/jC05y06iJl7ZKaf/gsVBHG+voFZXWiKWNCIaHJ9w4p3N T9P+dRtKzIf8o3Fa1Qj5jq6BWxWqOptwLuPWfqM+YQ== X-Google-Smtp-Source: ADUXVKJROlyDNpPGBtOUdGa3Cwe2D5hBkrAvOvIalFQUpfRvm31mu6d3F14tucHKTq3mRQ0wSvVXUcF3w0zfrXbKXaE= X-Received: by 2002:a0c:e401:: with SMTP id o1-v6mr743647qvl.66.1528947134744; Wed, 13 Jun 2018 20:32:14 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aed:3579:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 20:31:34 -0700 (PDT) In-Reply-To: <201806140328.w5E3SCZp042620@pdx.rh.CN85.dnsmgr.net> References: <201806140328.w5E3SCZp042620@pdx.rh.CN85.dnsmgr.net> From: Juli Mallett Date: Wed, 13 Jun 2018 20:31:34 -0700 Message-ID: Subject: Re: svn commit: r335091 - head/sbin/nvmecontrol To: rgrimes@freebsd.org Cc: Warner Losh , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 03:32:15 -0000 On 13 June 2018 at 20:28, Rodney W. Grimes wrote: > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > Author: imp > > > > Date: Wed Jun 13 22:00:02 2018 > > > > New Revision: 335091 > > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > > > > > > > Log: > > > > Make it possible to use print_controller from another program > > > > > > > > Rename print_controller to nvme_print_controller. Put it in its > > > > own file for easy inclusion. Move util.c to be nc_util.c to not > > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > > > > interfaces. > > > > > > > > Sponsored by: Netflix > > > > Differential Revision: https://reviews.freebsd.org/D15371 > > > > > > > > Added: > > > > head/sbin/nvmecontrol/identify_ext.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/ > identify.c > > > > head/sbin/nvmecontrol/nc_util.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > changed) > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > ... > > > > > > > > > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > > > r335089, head/sbin/nvmecontrol/util.c) > > > > ============================================================ > > > ================== > > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > > > (r335089, copy source) > > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 > 2018 > > > (r335091) > > > > @@ -1,7 +1,8 @@ > > > > /*- > > > > - * Copyright (c) 2017 Netflix, Inc > > > > - * All rights reserved. > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > > > * > > > > + * Copyright (C) 2018 Netflix > > > > > > You moved a copyright forward, that is not proper to do. > > > > > > > Thought it was. I honestly don't care where (nor does my employer), so if > > you want to tweak it to be more conforming, be my guest. > > You can add a new date to the end of a list, but you should always > retain the oldest date, and many opinions are that all dates should > be retained unless they are continuous. > Do you have a citation for this, Rod? I ask because my impression was that although it has often been done, and at one point may legitimately have been required, it is not any longer so. I'd love to have a concrete source on this, though. > It would be much simpler for you to commit: > - * Copyright (C) 2018 Netflix > + * Copyright (C) 2017-2018 Netflix > > Than for me to get approval: bde, phk. > > Thanks. > Rod > > > > > > Not sure about dropping the , Inc either. > > > > > > Doesn't matter. Different Netflix committers do different things and I > was > > trying to move towards uniformity. > > Ok > > > Warner > > -- > Rod Grimes > rgrimes@freebsd.org > >