From nobody Sat Apr 4 09:44:29 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fnrK93j0Wz6YLP3 for ; Sat, 04 Apr 2026 09:44:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fnrK92KBRz3Tnj for ; Sat, 04 Apr 2026 09:44:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775295869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u1C9cAlcKJg23yh8v90/FCJ6jWUhOAtaASYzycjBEm8=; b=LhIEg0sqwjf+CNnPU2EwTaKp/YyzIvKZclUNTNCFKRpn8DfG9YEoRHFVWCe9ewD5vPC7GT 96K+RglsRfAdlzTe5jyUx5/PitlVU86l34j2S4pkwJxOpkvXUGCjP2DNY7840WfpN3qtbL Amg9Jhdq0ljYWpXoIENrrkgDKBfFXefs1Hvs6eWi0IDI/fCLz8hKTTCFsTX2VoMspYoyjM HLW3cdtfmmEAY2adnqb32/gGq+eWHdff/rN67y+BS+VKXRX5omeabSyiblmRkEoWST3yh4 1Pd+82kk8DMnt4SJLDq38x9zIem7XoyOvIr1P39dtuu3HqawWJ3tICHZzv2KIQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775295869; a=rsa-sha256; cv=none; b=MPvirb/HdFgJP0QnJw+3uLEw0+2s3eyIhr9tayrdCBqRpaQ0oh1Dh6saSsacmGUzC4e9Fb QTmsfvnWlWqYAxWIaTfjxI5VFSId+VtkDfrzkjmj3j7CCPRTF0D/ORMyU5JfSjuJiKM+jw r9uVLph9KMQVkB+aPpZ7OlukheTAM2yiur46o9rTN7dPj6jp8xuKVEeSrWXENDP47HuOK0 dS4gzHxXYfTTNIIzRyI1lSqRPxrU8LwB9B8eqOSZNCW6dviPsayL9gXlZXDH2x5ATaGZHx iXXeOzEq94fCnlUMObU2QQHDT3RUAmnomkiQ84abrnbrcAQoJbU/IKAXDOqbIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775295869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u1C9cAlcKJg23yh8v90/FCJ6jWUhOAtaASYzycjBEm8=; b=SLTrvnSqWesNOOvr23Du6zDfs/dRJHmgrCFP3VgfjRhbDXxqlOqvC7Rw/jfisxZhT29DXg vqh1qHd6NXCAQzs84Clp9Hzru14x0qT3v85F2/aWiARw5CnB+u/Zx2uuCGkUzFwhfGdheo AVcX46wWVMGRUNByQtddIVtGiMZ/4x5vpE8EzeZlQXj4QvFODXaXQyRF2u5/ZAg1Zfw3x2 Wj+ncNrnDnxCyqZ3IAKyBVYefDlRG83wuxtBxveE3HdDJg/ybiJ44ayGc1H9U6v1rlHqXX XoF2TZa6f6SFiDH/lu+3zwMgt/xwpdS8tkpy4K3e5bFYBVAlACsG2ZLQSbZ86Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fnrK90qgkz1S15 for ; Sat, 04 Apr 2026 09:44:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cc85 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 04 Apr 2026 09:44:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dmitry Salychev Subject: git: c417ed80fd2f - stable/14 - dpaa2: Perform bus_dma pre-write sync before enqueue operation List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dsl X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c417ed80fd2fed7ae0561a5bf772408c910f2fec Auto-Submitted: auto-generated Date: Sat, 04 Apr 2026 09:44:29 +0000 Message-Id: <69d0dd7d.3cc85.7227606@gitrepo.freebsd.org> The branch stable/14 has been updated by dsl: URL: https://cgit.FreeBSD.org/src/commit/?id=c417ed80fd2fed7ae0561a5bf772408c910f2fec commit c417ed80fd2fed7ae0561a5bf772408c910f2fec Author: Dmitry Salychev AuthorDate: 2026-03-28 18:57:45 +0000 Commit: Dmitry Salychev CommitDate: 2026-04-04 09:44:07 +0000 dpaa2: Perform bus_dma pre-write sync before enqueue operation Without a proper synchronization payload of the egress TCP segments can be corrupted as tuexen@ described in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292006#c31. This patch is indirectly related to 292006 because a properly enabled and announced support for the TX checksum offloading hides potentially corrupted frame payload. PR: 292006 Reported by: tuexen@ Reviewed by: tuexen@ Tested by: dsl@, tuexen@ Differential Revision: https://reviews.freebsd.org/D56144 MFC after: 3 days (cherry picked from commit 5812415bee55a9063508b02fda9418b0eadb0bb4) --- sys/dev/dpaa2/dpaa2_ni.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/dpaa2/dpaa2_ni.c b/sys/dev/dpaa2/dpaa2_ni.c index 98a6c6047188..9389c6fff31a 100644 --- a/sys/dev/dpaa2/dpaa2_ni.c +++ b/sys/dev/dpaa2/dpaa2_ni.c @@ -3006,6 +3006,9 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, goto err_unload; } + bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); + bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); + /* TODO: Enqueue several frames in a single command */ for (int i = 0; i < DPAA2_NI_ENQUEUE_RETRIES; i++) { /* TODO: Return error codes instead of # of frames */ @@ -3015,9 +3018,6 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, } } - bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); - bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); - if (rc != 1) { fq->chan->tx_dropped++; goto err_unload;