Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Mar 2019 01:07:51 +0000 (UTC)
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r345430 - head/tests/sys/netpfil/pf
Message-ID:  <201903230107.x2N17pdC091972@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kp
Date: Sat Mar 23 01:07:51 2019
New Revision: 345430
URL: https://svnweb.freebsd.org/changeset/base/345430

Log:
  pf tests: Fix accidental duplication of content
  
  Also use the correct name for the scapy test script.

Modified:
  head/tests/sys/netpfil/pf/icmp.sh

Modified: head/tests/sys/netpfil/pf/icmp.sh
==============================================================================
--- head/tests/sys/netpfil/pf/icmp.sh	Sat Mar 23 00:22:29 2019	(r345429)
+++ head/tests/sys/netpfil/pf/icmp.sh	Sat Mar 23 01:07:51 2019	(r345430)
@@ -32,56 +32,7 @@ cve_2019_5598_body()
 		"pass in proto udp to 198.51.100.3 port 53" \
 		"pass out proto udp to 198.51.100.3 port 53"
 
-	atf_check -s exit:0 $(atf_get_srcdir)/CVE-2019-icmp.py \
-		--sendif ${epair_in}a \
-		--recvif ${epair_out}a \
-		--src 192.0.2.1 \
-		--to 198.51.100.3
-}
-
-cve_2019_5598_cleanup()
-{
-	pft_cleanup
-}
-
-atf_init_test_cases()
-{
-	atf_add_test_case "cve_2019_5598"
-}
-# $FreeBSD$
-
-. $(atf_get_srcdir)/utils.subr
-
-atf_test_case "cve_2019_5598" "cleanup"
-cve_2019_5598_head()
-{
-	atf_set descr 'Test CVE-2019-5598'
-	atf_set require.user root
-	atf_set require.progs scapy
-}
-
-cve_2019_5598_body()
-{
-	pft_init
-
-	epair_in=$(vnet_mkepair)
-	epair_out=$(vnet_mkepair)
-	ifconfig ${epair_in}a 192.0.2.1/24 up
-	ifconfig ${epair_out}a up
-
-	vnet_mkjail alcatraz ${epair_in}b ${epair_out}b
-	jexec alcatraz ifconfig ${epair_in}b 192.0.2.2/24 up
-	jexec alcatraz ifconfig ${epair_out}b 198.51.100.2/24 up
-	jexec alcatraz sysctl net.inet.ip.forwarding=1
-	jexec alcatraz arp -s 198.51.100.3 00:01:02:03:04:05
-	route add -net 198.51.100.0/24 192.0.2.2
-
-	jexec alcatraz pfctl -e
-	pft_set_rules alcatraz "block all" \
-		"pass in proto udp to 198.51.100.3 port 53" \
-		"pass out proto udp to 198.51.100.3 port 53"
-
-	atf_check -s exit:0 $(atf_get_srcdir)/CVE-2019-icmp.py \
+	atf_check -s exit:0 $(atf_get_srcdir)/CVE-2019-5598.py \
 		--sendif ${epair_in}a \
 		--recvif ${epair_out}a \
 		--src 192.0.2.1 \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903230107.x2N17pdC091972>