From owner-svn-src-all@freebsd.org Fri Jan 18 14:54:16 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FE0C14A1080; Fri, 18 Jan 2019 14:54:16 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7E828931DC; Fri, 18 Jan 2019 14:54:15 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0IEsB7t055785; Fri, 18 Jan 2019 06:54:11 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0IEsAWh055784; Fri, 18 Jan 2019 06:54:10 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901181454.x0IEsAWh055784@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r343118 - in head/usr.sbin: . trim In-Reply-To: <201901181254.x0ICsbBb076360@slippy.cwsent.com> To: Cy Schubert Date: Fri, 18 Jan 2019 06:54:10 -0800 (PST) CC: Eugene Grosbein , Maxim Sobolev , "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 7E828931DC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.93)[-0.933,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 14:54:16 -0000 > In message <81bb343b-ad8a-371d-d94f-f72c8dbce754@grosbein.net>, Eugene > Grosbein > writes: > > 18.01.2019 5:25, Maxim Sobolev wrote: > > > > > Using usr.sbin/trim as an example. > > > > We still lack a command usable at installation stage (escape to shell) to tri > > m a device or partition > > dedicated to ZFS Cache/ZFS Intention Log/zvol any other use when ports/packag > > es are not yet available. > > OK, I will put a review together for dd. Ignoring all the hyperbola below, here is what your looking for: https://reviews.freebsd.org/D18382 > > Do you realize that what you just said? Your statement is inconsistent > with where trim is installed? Then it should have been installed in > /sbin not where you put it. I don't want to start yet another bikeshed > arguing the merits of this or that -- I'm intentionally being vague > here because I really don't want to stat a different bikeshed thread. > But suffice it to say, dd is the place for it because it lives in /bin > and dd is already included in /rescue. > > Everything about trim is wrong, even where it is put. -- Rod Grimes rgrimes@freebsd.org