From owner-svn-ports-head@freebsd.org Thu Jul 14 18:55:12 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEE1BB99FE6; Thu, 14 Jul 2016 18:55:12 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F1611EC7; Thu, 14 Jul 2016 18:55:12 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f47.google.com with SMTP id u186so290437ita.0; Thu, 14 Jul 2016 11:55:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=bYl56b4rJgyl2YUzggPz+HXTAq+HO8eqQrrbNc/d+Ek=; b=SxPJt4VbBBDvgg7PtIV+8LMzbinbrCHM6C233AcMP0kSTYBdoMFz6e0xiOy75SmaB4 C2fL2PNq92rfS036dXBPIRSy92NVmD3NwEeBAs4ft3aD0DjVRgSPQX7JHzKboY3MyEbz h5rTwTKx0Df2II8Aomw5jNPEg+4cPmq9a44Fa+Amg16OkkfduXVrsNObqiDNhqBi6fEr pkjjtU/c9WBCUX/N1AkaZ1ia1EfCGilFui+fhIi4emxSkowC42bDnM5HZhEaVSF/WHAc 2ckFUEc9BZPiyESfj2VjdxyCnTPBqBZf3yZ4qPFM0MBNEzQYqwmNu799NciqQIJ1d4sq VRDw== X-Gm-Message-State: ALyK8tIXiNXyCpEk5LlOIPP20/fjZ1vyipnZXixyE6yx2XTxMooQXEzGdScshyNSklUxQQ== X-Received: by 10.36.129.86 with SMTP id q83mr16060155itd.35.1468522038962; Thu, 14 Jul 2016 11:47:18 -0700 (PDT) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com. [209.85.223.182]) by smtp.gmail.com with ESMTPSA id 188sm11778353itk.19.2016.07.14.11.47.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jul 2016 11:47:18 -0700 (PDT) Received: by mail-io0-f182.google.com with SMTP id b62so83891185iod.3; Thu, 14 Jul 2016 11:47:18 -0700 (PDT) X-Received: by 10.107.38.76 with SMTP id m73mr18819470iom.7.1468522038415; Thu, 14 Jul 2016 11:47:18 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.206.2 with HTTP; Thu, 14 Jul 2016 11:47:17 -0700 (PDT) In-Reply-To: References: <201607140142.u6E1g9Sp056312@repo.freebsd.org> <20160714084653.quyjmu7g3e4f7d5b@ivaldir.etoilebsd.net> From: Conrad Meyer Date: Thu, 14 Jul 2016 11:47:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r418510 - head/devel/elfutils To: Baptiste Daroussin Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 18:55:12 -0000 Nevermind, I have addressed this myself in r418553. Please don't commit :-). Best, Conrad On Thu, Jul 14, 2016 at 8:09 AM, Conrad Meyer wrote: > On Thu, Jul 14, 2016 at 1:46 AM, Baptiste Daroussin wrote: >> Which is exactly why non ports committers are not supposed to commit in the ports >> tree without a ports committer review/approval. > > Sorry. I'm doing my best with the porter's handbook, just like anyone else. > >> At least at quick glance there is this: >> - post-patch expects gnulib to already be installed but gnulib is a build >> dependency and not a patch dependency so not installed at the momemt you >> needed it > > Why have a PATCH_DEPENDS distinct from BUILD_DEPENDS? > >> - automake is not supposed to be run like this > > The port doesn't need a full autoreconf, just automake. It is > intended to work in isolation to configure.ac/configure.in. The > porter's handbook did not seem to provide any better direction here. > >> https://people.freebsd.org/~bapt/elfutils.diff >> >> Should fix those 2 issues > > Please go ahead and commit. > > Thanks, > Conrad