From owner-cvs-all Mon Oct 4 11:27: 4 1999 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id B24E615527; Mon, 4 Oct 1999 11:26:56 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id UAA07226; Mon, 4 Oct 1999 20:26:46 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Julian Elischer Cc: Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/iicbus iic.c In-reply-to: Your message of "Mon, 04 Oct 1999 11:04:25 PDT." Date: Mon, 04 Oct 1999 20:26:46 +0200 Message-ID: <7224.939061606@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk No, Now I'm arguing that the cdevsw_add() should never be done. Please see the "heads up" I sent today. Poul-Henning In message , Julian Elischer writes: >Poul is arguing (in my opinion wrongly) that the cdevsw_add should be done >on the attach of the forst found example, and not in the DEV_DRIVER_MODULE >code. > >julian > > > > > >On Mon, 4 Oct 1999, Peter Wemm wrote: > >> peter 1999/10/04 08:53:09 PDT >> >> Modified files: >> sys/dev/iicbus iic.c >> Log: >> Fix: WARNING: "iic" is usurping "iic"'s cdevsw[] - the DEV_DRIVER_MODULE() >> takes care of the cdevsw_add() - it doesn't need to be done twice. >> >> Revision Changes Path >> 1.16 +1 -5 src/sys/dev/iicbus/iic.c >> >> >> > > > -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message