From owner-cvs-all@FreeBSD.ORG  Wed Apr 21 07:29:21 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0C6A416A4CE; Wed, 21 Apr 2004 07:29:17 -0700 (PDT)
Received: from localhost (green@localhost [127.0.0.1])
	by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i3LESrYq042686;
	Wed, 21 Apr 2004 10:28:58 -0400 (EDT)
	(envelope-from green@green.homeunix.org)
Message-Id: <200404211428.i3LESrYq042686@green.homeunix.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Alexander Leidinger <Alexander@Leidinger.net>
In-Reply-To: Message from Alexander Leidinger <Alexander@Leidinger.net> 
	<20040421135340.56f36568@Magellan.Leidinger.net> 
From: "Brian F. Feldman" <green@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 21 Apr 2004 10:28:53 -0400
Sender: green@green.homeunix.org
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/sound/pci cmi.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2004 14:29:21 -0000

Alexander Leidinger <Alexander@Leidinger.net> wrote:
> On Tue, 20 Apr 2004 21:23:51 -0700 (PDT)
> Brian Feldman <green@freebsd.org> wrote:
> 
> > green       2004/04/20 21:23:51 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/sound/pci    cmi.c 
> >   Log:
> >   This driver certainly works fine turning INTR_MPSAFE back on.  For those
> >   of you with other cards, please do review and test the drivers for
> >   MP-safety and disable Giant in the interrupt routines when you are
> >   sure of proper functionality.
> 
> How to test it? Just mark it as MP-safe and play some audio?

In this case, I reviewed the lock usage in the code to make sure that it 
protected the softc correctly, and to make sure I tested out all of the play 
and all of the record channels and the mixer at once.  I don't think that 
there is really any more you could do than that, and luckily, the drivers 
are generally simple.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\