Date: Tue, 14 May 2013 16:35:38 GMT From: Boris Samorodov <bsam@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/178634: [patch] net-mgmt/collectd5: add LIB_DEPENDS Message-ID: <201305141635.r4EGZcLm077341@oldred.FreeBSD.org> Resent-Message-ID: <201305141640.r4EGe5VO085661@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 178634
>Category: ports
>Synopsis: [patch] net-mgmt/collectd5: add LIB_DEPENDS
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Tue May 14 16:40:05 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Boris Samorodov
>Release: FreeBSD 9-i386
>Organization:
BSDprint
>Environment:
FreeBSD srv.bb.tel.ru 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #7 r243514: Sun Nov 25 20:10:07 SAMT 2012 bsam@srv.bb.tel.ru:/usr/obj/usr/src/sys/BB i386
>Description:
. add libnotify to LIB_DEPENDS (which is needed for world as per configure.log);
. bump PORTREVISION.
Here is the relevant part from the configure.log:
-----
Configuration:
Libraries:
[...]
libnotify . . . . . . no (Package libnotify was not found in the pkg-config search path.
Perhaps you should add the directory containing `libnotify.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libnotify', required by 'world', not found)
-----
PS. Please, keep in mind that I'll submit several PRs on the port as I treat those changes differently. This one imho right but I'm not sure. The maintainer should know better.
>How-To-Repeat:
Try to build the port at a vanilla system and lok at the configure.log.
>Fix:
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 317544)
+++ Makefile (working copy)
@@ -2,13 +2,15 @@
# $FreeBSD$
PORTNAME= collectd
PORTVERSION= 5.2.1
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= net-mgmt
MASTER_SITES= http://collectd.org/files/
MAINTAINER= ports@bsdserwis.com
COMMENT= Systems & network statistics collection daemon
+LIB_DEPENDS= notify:${PORTSDIR}/devel/libnotify
+
USE_BZIP2= yes
USE_GMAKE= yes
GNU_CONFIGURE= yes
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305141635.r4EGZcLm077341>