From owner-freebsd-current  Sat Mar  8  9:28:19 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 47A5B37B401
	for <freebsd-current@FreeBSD.ORG>; Sat,  8 Mar 2003 09:28:18 -0800 (PST)
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3FF5143F93
	for <freebsd-current@FreeBSD.ORG>; Sat,  8 Mar 2003 09:28:17 -0800 (PST)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: from khavrinen.lcs.mit.edu (localhost.ipv6.lcs.mit.edu [IPv6:::1])
	by khavrinen.lcs.mit.edu (8.12.8/8.12.8) with ESMTP id h28HSDCd039987
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Sat, 8 Mar 2003 12:28:14 -0500 (EST)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.12.8/8.12.8/Submit) id h28HSDWM039984;
	Sat, 8 Mar 2003 12:28:13 -0500 (EST)
	(envelope-from wollman)
Date: Sat, 8 Mar 2003 12:28:13 -0500 (EST)
From: Garrett Wollman <wollman@lcs.mit.edu>
Message-Id: <200303081728.h28HSDWM039984@khavrinen.lcs.mit.edu>
To: Craig Rodrigues <rodrigc@attbi.com>
Cc: freebsd-current@FreeBSD.ORG
Subject: #warning must be protected by #if __GNUC__ in headers?
In-Reply-To: <20030308161943.GA54921@attbi.com>
References: <20030308161943.GA54921@attbi.com>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

<<On Sat, 8 Mar 2003 11:19:43 -0500, Craig Rodrigues <rodrigc@attbi.com> said:

> Does the use of #warning need to be protected by
> #if __GNUC__ in FreeBSD header files?

No, it needs to be replaced by the standard `#error' directive
instead.  I asked portmgr to do a run on the portsd cluster with this
change to look for ports that mistakenly include this file, but I
never heard back and portmgr is now busy doing the packages for 4.8.

`#if __GNUC__' wouldn't help matters; every preprocessor has to read
and interpret every preprocessor directive (so that `#else' and
`#endif' can be recognized).

-GAWollman


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message