From owner-svn-ports-all@freebsd.org Mon Sep 14 22:40:00 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BEDC13E3D62; Mon, 14 Sep 2020 22:40:00 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Br1X04dzqz4QW4; Mon, 14 Sep 2020 22:40:00 +0000 (UTC) (envelope-from jbeich@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1600123200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZGkkbKbZgEWkRwWH+TrNo2THo084h7jN7Ugy/tnjnQ=; b=rx9mybPX4ijVQ2KBNz1nv8G/ex8NtPEfeGl/yNgOHazB1Wkl1ld4D4Zz1YZbTixWpXMXjA tfau5s1KrArtJ5SwEGAyWkV23keoBzf7wkI1vtgvyPTHFWflF9EJtKw+G+cwg29GmufzxE TYJk7vtmUmXDbl7vrSd1h9DUCmJiE76hlKHHkikzob3ToJFRNw2RlWVowXkcCKZshY2C+x dJ9DG2xmFqLY3hEeS8GypRyBI0gITAepOXQqdf11uGaOr2zvho86RXsFPVcB8P2TD6Qy+F qTouvHHO/vi404bVgtnEpDNmS1JmMNAX/PCA0sNq+gDvtdD7Azxee8F9Pd1dFQ== Received: by freefall.freebsd.org (Postfix, from userid 1354) id 984261DACB; Mon, 14 Sep 2020 22:40:00 +0000 (UTC) From: Jan Beich To: Emmanuel Vadot Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r548253 - in head/graphics: . glx-utils mesa-demos References: <202009111728.08BHShvE009018@repo.freebsd.org> <20200914164152.fe53cfb4b24b1d184e646c0f@bidouilliste.com> <20200914222242.507a38256bbaf622cd85fcb4@bidouilliste.com> Date: Tue, 15 Sep 2020 00:39:57 +0200 In-Reply-To: <20200914222242.507a38256bbaf622cd85fcb4@bidouilliste.com> (Emmanuel Vadot's message of "Mon, 14 Sep 2020 22:22:42 +0200") Message-ID: <1rj4-0ypu-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1600123200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZGkkbKbZgEWkRwWH+TrNo2THo084h7jN7Ugy/tnjnQ=; b=GRyFZs8WkBUDgn4GWgegupg/vOShazlE1tLP5Z0INdRGJA0iqnnTNYXxDO7BNZZCvsAwzP EyXuDIuzDsZpsklGnGD/d4l/+tJRvSRNO59qWVF1el/bUDe4Ku1dAHPTdR0N6PI5vxCMir pp8yg+InhYFusytkKFe0sHnl5YEx6Fl4Yq/hSyehSCHad87OOxZ89PJ7qpnk89CZbnsED4 fyD21SW6HQIiQ4iPwrl4tpgEZ/513Gia07JltpmtGwxNuzVNjA3B8Hu5CU8y9ndBHFdhuc EsyaMYcOUfq37ClFEPo39RQZh3HiaMmjn/gOLy2KWHSgwLkHSxZBijiz8mXiMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1600123200; a=rsa-sha256; cv=none; b=bwLvDXTwtAnGNQd7fPFFUUCBVaBByjcuTAfPavzzQbJ9ilPspCYmnRhHGoVBw9DyLUm/Bv 0RM845U8qV6z5jMdr6BvBtXavkkf7rETu2z7VE6qK9aay4O/5Wndrz/TLv34KsC+pCxhmT r+O3bcJzyDi8mZagNabjnBiYlLAyn+xVqcTGooaP1S7Q/hZLqrd3i/aL4DWhuxz1u3vAV3 e3OqdEXnIxk80+omZhdYvtZxv1TbzHs8T/0ZVVyol2jLK5n57hvAofuJoKLdV7sQ7gysd7 wtFtoCU6flnyZjL09vn/kE7L3m4aKS6I7j1Dx6BOqnPQBo8Z7KZmMI1qFlhJtg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 22:40:00 -0000 Emmanuel Vadot writes: > On Mon, 14 Sep 2020 20:19:45 +0200 > Jan Beich wrote: > >> Emmanuel Vadot writes: >> >> > On Fri, 11 Sep 2020 17:28:43 +0000 (UTC) >> > Jan Beich wrote: >> > >> >> Author: jbeich >> >> Date: Fri Sep 11 17:28:43 2020 >> >> New Revision: 548253 >> >> URL: https://svnweb.freebsd.org/changeset/ports/548253 >> >> >> >> Log: >> >> graphics/glx-utils: add new port >> >> >> >> A few popular OpenGL X11 demos from Mesa: >> >> >> >> - glxinfo prints capabilities of OpenGL driver >> >> - glxgears draws rotating gears and prints FPS >> >> >> >> Inspired by: D26077, glx-utils (CentOS, PkgSrc), glxinfo (AUR, MacPorts, Nix) >> >> Motivated by: testing GLX on Xwayland, avoiding cruft and extra deps >> >> >> >> Added: >> >> head/graphics/glx-utils/ >> >> head/graphics/glx-utils/Makefile (contents, props changed) >> >> head/graphics/glx-utils/distinfo (contents, props changed) >> >> head/graphics/glx-utils/pkg-descr (contents, props changed) >> >> Modified: >> >> head/graphics/Makefile (contents, props changed) >> >> head/graphics/mesa-demos/Makefile (contents, props changed) >> >> >> > >> > Saw this commit on Friday evening and decided to not answer as I >> > wanted to spend a nice weekend. >> > Now that I'm back, what the fuck ? Seriously what the fuck ? >> > >> > You see a review where a commiter start to address a problem, decide >> > that it's not the right way to do it and instead of talking to him you >> > just commit your way of solving the problem ? >> > And now we're suppose to adapt to your way of handling this problem >> > without prior discussion ? >> > It's freebsd-ports, not jbeich-ports. >> >> D26077 didn't have feedback for ~1 month. > > Maybe because Tobias spent the last few weeks fixing -fno-common for a > lot of ports ? D26077 requested review from zeising@, not tcberner@. By the state it looked like D26077 was on backburner. Self-review in absence of feedback is rare, especially weeks after submitting a change. And finding a committer without backlog is a challenge. As I had a similar goal I've provided my review but it wasn't very valuable without showing how. glx-utils is just a prototype. If you're giving up just because it exists then maybe you don't care much about mesa-demos. > >> I've added glx-utils mainly for myself (see Motivated by) after analyzing prior art. Why do I need >> to justify every port for you? > > This is not about justifying to me but to all ports commiters, again > the ports tree isn't yours. Who else? After mentorship ends every ports committer has a degree of autonomy. Being a volunteer my work is mainly motivated by intrinsic reasons. I don't get your patronizing attitude. >> If you don't like the approach disapprove/reject patches touching your or x11@ ports. >> >> Please, blame me for regressions or more work instead. > > This is not how the ports tree is supposed to work. Every port has a distinct MAINTAINER. Cooperation is only required when touching ports by others. portmgr granted a number of blankets in order to reduce friction from cooperation for trivial stuff. There's no mandatory review like in some other projects. Even then I could've asked someone outside of x11@ for review because it was a new port. >> > I still don't understand that you're not willing to send a email >> > stating your plan before commiting stuff. There was no hurry in >> > commiting this without prior discussion. This is not the first time >> > that you do that and you still don't understand. >> >> Burnout and non-zero backlog. For example, I wouldn't have worked on >> improving mesa-demos even if the planning decided creating a separate >> port wasn't a good idea. For unrelated example, planning didn't help D25020. > > If you're burnt out stop commiting things. I'm burnt out dealing with x11@, so subconsciously avoid touching their ports. Sometimes I submit patches only for those to bitrot in bugzilla/phabricator. Sometimes progressing on my work requires creating new ports like glx-utils. >> > It's really demotivating *not* working with you. >> >> Sorry, I don't like close cooperation. Collaborating on a common goal is >> fine but if you want to micromanage maybe just do the work yourself. > > This is not about micromanage for fuck sake, if you don't like > cooperation don't bother commit to something handled by multiple > persons. Planning how to implement a simple fix constitutes a "close" cooperation. Do you mean to not bother with CONFLICTS* or not comment on reviews for other ports? If I've acted in bad faith neither would be the case, leaving you to do duplicated work months later.