From nobody Wed Dec 27 15:31:41 2023
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T0bGP4Lv4z55pmK;
	Wed, 27 Dec 2023 15:31:41 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4T0bGP3mdWz3LCX;
	Wed, 27 Dec 2023 15:31:41 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1703691101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZrJPeDcIoNb216oUNVcpOUhT4lIm181y5d+mmY4vOxc=;
	b=XsZU1aY6Tos4jg6pD3P8HXSpN7CcRabkClxdv+0mexI2PfJLNPosExIEa/Oj3NrtGDEsI/
	QaaBBC0LD0XyjeUp335Fn7OHbt+IHxUt/NoC7t9xN0bgFkyGieqBFEg13kD5osQikR2Ath
	OWPjwLJz0g3+IO7fFGuTM2p0KHYLMwdbcsBAQ+9RqNL2tSm+cl+kUktV+aP+iTn4jCdL7N
	fCSzzHEKnyy+tH0eoooa4mreL17rqANuAGx6TIhu4xtaVOO5KLmEu/BGHHrsHGfo0rNCs4
	wqIG0rG8WBwkaBheiX/00zDsNd1QCkIQOoyUDCPjLQqynnSpPUdTeRu8LRF+Ag==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703691101; a=rsa-sha256; cv=none;
	b=qom9tmfNga/HCXJ2pO4BgMIznMa4t+wLVdlE5OVct5v8r8rUAgqwn+yRjIc2BGP5Pqc2Vi
	YQNP20Sy4LxHltWbR2pVwaZPPCAITZTzeDwr9X7Le/RzRA1erq7kiJWWWSRM4rYW0Q0P+q
	MZaugAU/d+1+9ydqDtKEPn5H7dFsUQhyasv0Aq8NGbm0zP6AdeE7xrKJ7YPiQpx6SMVMDk
	r4W8orWWQjdixKzsLDI1NJhwknJEOMtSYexP6kHkTBp5AHVM/sBLe8e1V31SQ2LQMiAAmT
	j80WNoHe0ngReBpOEr+1d0p6IX9g7Za8kY6bKQXT9DMCqAr/HVm/Kh0fHUuvTQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1703691101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ZrJPeDcIoNb216oUNVcpOUhT4lIm181y5d+mmY4vOxc=;
	b=PYPDXghOTDJTMp045hDHFKS3/1aLjEbpak87Y/0gBrYg+o7auT4PlHQ37V/VVtkUgIVP1l
	tA8wyFmPiL5xW35j0HSP5EE0+/9RVBpRcYC5eswiJYVGIy1ia94PlJzbClOmN7otvSSIir
	KspUSL1WB3Y6z3/G5wVurBeXJf8vfKx3LFj8htFTUIMNlCHwhv0gcbLhQEfonn4jKr9fjv
	fBBiJjuQxmUVUAZTID8Zqw3uqVxm5kBPxe5nYOsTgzQic4E8DqM06Zw4QAxJdaGPpSfxp8
	YMsbn17/xrmqRXzewgbLvMshmxyBgKfqmantsUW3PoM98dTNvay0XqpP1jlhhg==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id 6425C1D531; Wed, 27 Dec 2023 15:31:41 +0000 (UTC)
Date: Wed, 27 Dec 2023 15:31:41 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Kyle Evans <kevans@freebsd.org>, src-committers@freebsd.org,
	dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject: Re: git: 6ac7c9f06ae9 - main - daemon: remove redundant parameter
 from listen_child()
Message-ID: <ZYxDXbj50bjYrxC0@FreeBSD.org>
References: <202312270608.3BR688vs024888@gitrepo.freebsd.org>
 <ZYw5cGZAuLSbO8AW@kib.kiev.ua>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZYw5cGZAuLSbO8AW@kib.kiev.ua>

On Wed, Dec 27, 2023 at 04:49:20PM +0200, Konstantin Belousov wrote:
> On Wed, Dec 27, 2023 at 06:08:08AM +0000, Kyle Evans wrote:
> > commit 6ac7c9f06ae9b7ef070c1f8a57dcc52be4dd45b7
> > 
> >   daemon: remove redundant parameter from listen_child()
> > 
> >   state already contains pipe fd
> > ...
> > @@ -448,9 +448,7 @@ daemon_eventloop(struct daemon_state *state)
> >  					/* child is dead, read all until EOF */
> >  					state->pid = -1;
> >  					state->mode = MODE_NOCHILD;
> > -					while (listen_child(state->pipe_fd[0],
> > -					    state))
> > -						;
> > +					while (listen_child(state));
> 
> This line is the style regression.

We've seen this before and I reckon these regressions would keep happening
when semicolon is put on the new line by itself alone.  This would be less
likely to happen and makes the intention more obvious to say ``continue;''.

./danfe