From owner-svn-src-head@FreeBSD.ORG Mon May 19 18:41:56 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95A1C1D9; Mon, 19 May 2014 18:41:56 +0000 (UTC) Received: from mail.ipfw.ru (mail.ipfw.ru [IPv6:2a01:4f8:120:6141::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 58DA62999; Mon, 19 May 2014 18:41:56 +0000 (UTC) Received: from 95.108.170.210-red.dhcp.yndx.net ([95.108.170.210] helo=ptichko.yndx.net) by mail.ipfw.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76 (FreeBSD)) (envelope-from ) id 1WmObF-000JOr-1o; Mon, 19 May 2014 18:31:33 +0400 Message-ID: <537A5014.7020001@FreeBSD.org> Date: Mon, 19 May 2014 22:40:20 +0400 From: "Alexander V. Chernikov" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Nikolai Lifanov , src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r266310 - in head: sbin/ipfw sys/netinet sys/netpfil/ipfw References: <201405171345.s4HDj3LK020332@svn.freebsd.org> <537A4D6D.7070608@mail.lifanov.com> In-Reply-To: <537A4D6D.7070608@mail.lifanov.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 May 2014 18:41:56 -0000 On 19.05.2014 22:29, Nikolai Lifanov wrote: > On 05/17/14 09:45, Alexander V. Chernikov wrote: >> Author: melifaro >> Date: Sat May 17 13:45:03 2014 >> New Revision: 266310 >> URL: http://svnweb.freebsd.org/changeset/base/266310 >> >> Log: >> Fix wrong formatting of 0.0.0.0/X table records in ipfw(8). >> >> Add `flags` u16 field to the hole in ipfw_table_xentry structure. >> Kernel has been guessing address family for supplied record based >> on xent length size. >> Userland, however, has been getting fixed-size ipfw_table_xentry structures >> guessing address family by checking address by IN6_IS_ADDR_V4COMPAT(). >> >> Fix this behavior by providing specific IPFW_TCF_INET flag for IPv4 records. >> >> PR: bin/189471 >> Submitted by: Dennis Yusupoff >> MFC after: 2 weeks >> >> Modified: >> head/sbin/ipfw/ipfw2.c >> head/sys/netinet/ip_fw.h >> head/sys/netpfil/ipfw/ip_fw_table.c >> > This seems to break things for me: > > ===> sbin/ipfw (all) > cc -O2 -pipe -march=corei7-avx -DPF -g -std=gnu99 -fstack-protector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int > -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value > -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion > -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter > -Qunused-arguments -c /usr/src/sbin/ipfw/ipfw2.c > /usr/src/sbin/ipfw/ipfw2.c:4392:15: error: no member named 'flags' in > 'struct > _ipfw_table_xentry' > if ((xent->flags & IPFW_TCF_INET) != 0) { > ~~~~ ^ > /usr/src/sbin/ipfw/ipfw2.c:4392:23: error: use of undeclared identifier > 'IPFW_TCF_INET' > if ((xent->flags & IPFW_TCF_INET) != 0) { It looks like your build is using old ip_fw.h version. Are you doing clean buildworld? > ^ > 2 errors generated. > *** Error code 1 > > Stop. > > I'm building from 266216, and I tried several revisions in between this > one and r266447. > > - Nikolai Lifanov > > >