From owner-freebsd-stable@freebsd.org Mon Oct 22 14:32:59 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6850FFE161 for ; Mon, 22 Oct 2018 14:32:59 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:d12:604::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2C6EB7CA3D; Mon, 22 Oct 2018 14:32:59 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w9MEWqS1009876 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Oct 2018 16:32:53 +0200 (CEST) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: avg@FreeBSD.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w9MEWofw074763 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 22 Oct 2018 21:32:50 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: krpc: unbootable ZFS-on-root after major upgrade to 11.2 To: Andriy Gapon , Glen Barber References: <8517429b-9e3b-2ea3-80a6-12fc92106252@grosbein.net> <6627d159-fd52-2d10-2d45-97fd02725adc@FreeBSD.org> <5BC9A2E4.9010306@grosbein.net> <6c2f8adb-c0e7-550b-8595-e7a4768d5157@FreeBSD.org> <20181022140304.GE13668@FreeBSD.org> <1d5236b8-0269-5dce-3f2e-e7b1910836c6@grosbein.net> <20181022141527.GF13668@FreeBSD.org> Cc: FreeBSD stable From: Eugene Grosbein Message-ID: <8b31ed45-eddb-e93e-57f6-4bc1387d18ff@grosbein.net> Date: Mon, 22 Oct 2018 21:32:45 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,LOCAL_FROM,SPF_PASS autolearn=no autolearn_force=no version=3.4.1 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 SPF_PASS SPF: sender matches SPF record * 2.6 LOCAL_FROM From my domains X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 14:32:59 -0000 22.10.2018 21:21, Andriy Gapon wrote: >>>>> Glen, maybe that errata record should be deleted. The problem is real but it is long-standing >>>>> and present in 10.x too. >>>>> >>>> >>>> Could you elaborate more on the failure case you originally reported >>>> first? If the problem is real, my feeling is that the errata entry >>>> should stay, just worded differently to reflect the failure case here. >>> >>> zfs.ko depends on krpc.ko. The KRPC code in compiled in GENERIC kernel as dependency >>> of NFS client/server code. The problem arises if all of these are true: >>> >>> 1) a system uses custom kernel with NFS options removed; >>> 2) there is no krpc.ko available due to MODULES_OVERRIDE excluding it; >>> 3) the system boots off ZFS pool. >>> >>> In such case, loader cannot resolve dependency and fails to load zfs.ko >>> and kernel fails to mount root breaking boot sequence. >>> >>> >> >> So, if I understand correctly (and please correct me if I am wrong), the >> majority of the text in the errata note is correct, however needs to be >> tweaked to remove "upgrading from 10.x...". Is this generally correct? Yes. > This is just a typical foot-shooting (and a shortcoming of the kernel build > system that allows such foot-shooting to happen). > I think that there can be other ways in which you can specify inconsistent > kernel options and/or an incorrect subset of modules in MODULES_OVERRIDE to > create missing dependencies for critical modules. > Do we want to issue an errata for each possible misconfiguration? OTOH, we have option krpc in sys/conf/options but it is not mentioned elsewhere: not in the Handbook nor in the sys/conf/NOTES or GENERIC. Not a bit of our documentation mentions that ZFS requires KRPC for last 10 years. One can call it foot-shooting if it is against documentation but that's not the case.