From owner-svn-src-all@freebsd.org  Tue Mar  7 05:50:27 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56A36D01B35;
 Tue,  7 Mar 2017 05:50:27 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0BF441364;
 Tue,  7 Mar 2017 05:50:26 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v275oOVJ092698;
 Mon, 6 Mar 2017 21:50:24 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v275oOE5092697;
 Mon, 6 Mar 2017 21:50:24 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201703070550.v275oOE5092697@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder
 libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd
 usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin
In-Reply-To: <21A8D529-BFB9-4774-83FB-5CABD2BC689C@gmail.com>
To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
Date: Mon, 6 Mar 2017 21:50:24 -0800 (PST)
CC: "Rodney W. Grimes" <rgrimes@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Mar 2017 05:50:27 -0000

> > On Mar 6, 2017, at 21:10, Rodney W. Grimes <rgrimes@FreeBSD.org> wrote:
> > 
> > Author: rgrimes
> > Date: Tue Mar  7 05:10:38 2017
> > New Revision: 314833
> > URL: https://svnweb.freebsd.org/changeset/base/314833
...

> > 
> > -SYMLINKS+=	${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> > +SYMLINKS+=	../../../tests/lib/libxo/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> 
> 	This change breaks setting TESTSBASE != /usr/tests . Please fix (my employer depends on this being functional).
> Thanks,

I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS and
probably a much better fix in bsd.*.mk can be implemented.  I can live with
one last nasty wart of an absolute link in DESTDIR until then.  The important
functional ones are gone now.

To fix this without changing SYMLINKS would involve adding a local install:
target which would be more mess than having the one absolute link.

> -Ngie

-- 
Rod Grimes                                                 rgrimes@freebsd.org