From owner-freebsd-firewire@FreeBSD.ORG  Wed Dec 17 07:00:25 2008
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 196401065674;
	Wed, 17 Dec 2008 07:00:25 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id C64458FC40;
	Wed, 17 Dec 2008 07:00:24 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mBH6xbN5070526;
	Tue, 16 Dec 2008 23:59:37 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 16 Dec 2008 23:59:41 -0700 (MST)
Message-Id: <20081216.235941.1266245051.imp@bsdimp.com>
To: freebsd@sopwith.solgatos.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200812170329.DAA17848@sopwith.solgatos.com>
References: <4947EAB0.3020704@miralink.com>
	<200812170329.DAA17848@sopwith.solgatos.com>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-firewire@freebsd.org, freebsd-drivers@freebsd.org,
	bug-followup@freebsd.org
Subject: Re: kern/118093: firewire bus reset hogs CPU, causing data to be
 lost 
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Firewire support in FreeBSD <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Dec 2008 07:00:26 -0000

In message: <200812170329.DAA17848@sopwith.solgatos.com>
            Dieter <freebsd@sopwith.solgatos.com> writes:
: Sean>  Which file in dev/firewire are you looking at?
: 
: fwohci.c  and  firewire.c
: 
: examples:
: 
: printf("non CYCLEMASTER mode\n");
: 
: device_printf(fc->dev, "Initiate bus reset\n");
: 
: -------------------
: 
: Warner>  This can't be the case.  There's no SPL involved at all.  Maybe
: Warner>  removing the printfs causes an interrupt to be serviced faster,
: Warner>  resulting in what appears to be better performance...
: 
: With the printfs, Ethernet is not getting serviced.  This
: is repeatable and easily reproduced.   Without the printfs,
: it seems ok.
: 
: If it isn't spl, what is locking out Ethernet?

interrupt storm?  In old-spl-locked drivers, often times the interrupt
would be masked while certain operations happened.  In new
mutex-locked freebsd, there's no way to block the interrupts, so
sometimes old code gets into an interrupt storm, which starves other
things.  Not sure why printf would trigger this, however...

Warner