From owner-svn-src-head@freebsd.org Sat Mar 31 17:33:44 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0EAAF72BB6; Sat, 31 Mar 2018 17:33:43 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 546E76DA69; Sat, 31 Mar 2018 17:33:43 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: by mail-lf0-f41.google.com with SMTP id t132-v6so16003862lfe.2; Sat, 31 Mar 2018 10:33:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=MoeSSxj/1Rvl5UqoMUbezbSEASz5Dzt9qtyxRIDhyMs=; b=IZRRZJNw5ULgcfXs/8/OH65NJlB5sJGTsPzeMX/0PXrXBvSUkRyrupmey2/dRbXS5W nO8AH89L/giMtOnMtxBSDi02Lo72T0AvDOh0pi7hHeanE7Gv++FvkiSPdFYQPK50H9Qs txhinF2yoq2NzcracZKb/dsIZ+LKmbM64uj5Uyv7fRyXH1QvjCoFT0jvgnI+t3FqMnFi HPzlnMuaF+kyV3+0+Ev8FehyCvC6+BFcxk0eUgBLWPy5mVLQ6VR7d+1+5rWQtGxziCLA +2ENUrC1O3ZU0wXmsjb3K8844MNWCCDOVAsiGQEtvnzG4CCl0vxtlvCUilABfDeF+oFY gaPw== X-Gm-Message-State: ALQs6tD/KVJEuHwm21UvKMRr0zBAFmw7YDuczllwN5gfFN1O5tPr9LFe lo/i2EUcLnlKQtn3ISvvuCUerw4P X-Google-Smtp-Source: AIpwx4+7hqR095oRl0uXVn3oPIjuNajXfwJnLAlYpRNr3ZXmwjMJIuj4xDO9prJiHc/x4+l2fEV69A== X-Received: by 2002:a19:2c85:: with SMTP id s127-v6mr2202004lfs.18.1522517616094; Sat, 31 Mar 2018 10:33:36 -0700 (PDT) Received: from localhost (46-133-77-179.dialup.umc.net.ua. [46.133.77.179]) by smtp.gmail.com with ESMTPSA id l24sm1899399ljb.60.2018.03.31.10.33.34 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 31 Mar 2018 10:33:35 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Harry Schmalzbauer" Cc: "Bryan Drewery" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r324673 - head/sys/kern References: <201710162146.v9GLkB6t036842@repo.freebsd.org> <5305175e-e8d2-453d-9ba6-0281af1582a9@FreeBSD.org> <5ABF5296.3050307@omnilan.de> Date: Sat, 31 Mar 2018 20:31:11 +0300 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: <5ABF5296.3050307@omnilan.de> User-Agent: Opera Mail/12.15 (FreeBSD) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2018 17:33:44 -0000 Sat, 31 Mar 2018 12:19:18 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Harry Schmalzbauer = : > Bez=C3=BCglich Andriy Voskoboinyk's Nachricht vom 17.10.2017 00:50 = > (localtime): >> Tue, 17 Oct 2017 00:53:28 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0= =D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Bryan Drewery >> : >> >>> On 10/16/2017 2:46 PM, Andriy Voskoboinyk wrote: >>>> Author: avos >>>> Date: Mon Oct 16 21:46:11 2017 >>>> New Revision: 324673 >>>> URL: https://svnweb.freebsd.org/changeset/base/324673 >>>> >>>> Log: >>>> mbuf(9): unbreak m_fragment() >>> >>> How was it broken >> >> Due to m_cat() usage reason (as described below); this part was >> not changed since function creation in r119644. >> >>> and since when? >> >> No idea here - probably, it was partially working until m_cat() >> improvement in r242256. >> >> P.S. Just checked with m_fragment(m, M_NOWAIT, -2) placed >> right before ieee80211_mbuf_defrag() (from D4077) and >> various m_len printf's before and after - it defragments >> frames before this change and works as intended after it. >> >>> >>>> >>>> - Fix it by replacing m_cat() with m_prev->m_next =3D m_new >>>> (m_cat() will try to append data - as a result, there will be no >>>> fragmentation). >>>> - Move some constants out of the loop. >>>> >>>> Was previously tested with D4077. >>>> >>>> Differential Revision: https://reviews.freebsd.org/D4090 > > > Will r324673 be MFCd before 11.2? > > Thanks, > > -harry Done in r331847.