From owner-cvs-all Fri Feb 22 14:18:31 2002 Delivered-To: cvs-all@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id 671DE37B402; Fri, 22 Feb 2002 14:18:19 -0800 (PST) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id RAA13583; Fri, 22 Feb 2002 17:18:18 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id g1MMHmX82647; Fri, 22 Feb 2002 17:17:48 -0500 (EST) (envelope-from gallatin@cs.duke.edu) Date: Fri, 22 Feb 2002 17:17:48 -0500 From: Andrew Gallatin To: Mike Barcroft Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/games/fortune/fortune fortune.c src/games/fortune/strfile strfile.c src/games/fortune/unstr unstr.c src/include/arpa inet.h src/include/rpc xdr.h src/lib/libc/alpha/net byte_swap_2.S byte_swap_4.S htonl.S htons.S ntohl.S ntohs.S ... Message-ID: <20020222171748.A81125@grasshopper.cs.duke.edu> References: <200202182035.g1IKZRX56719@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200202182035.g1IKZRX56719@freefall.freebsd.org>; from mike@FreeBSD.org on Mon, Feb 18, 2002 at 12:35:27PM -0800 X-Operating-System: FreeBSD 4.4-RELEASE on an i386 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG When compiling a kernel on alpha, I now see: "warning: implicit declaration of function `__ntohs'" In all places which use ntohs(), similar for the other 3 byteswapping routines. Don't you think these should at least be prototyped in sys/alpha/include/endian.h?? Does this look OK? It seems to fix the compile warnings, but I don't know what your plans are.. Drew Index: alpha/include/endian.h =================================================================== RCS file: /home/ncvs/src/sys/alpha/include/endian.h,v retrieving revision 1.6 diff -u -r1.6 endian.h --- alpha/include/endian.h 18 Feb 2002 20:35:20 -0000 1.6 +++ alpha/include/endian.h 22 Feb 2002 22:14:57 -0000 @@ -58,4 +58,11 @@ #define BYTE_ORDER LITTLE_ENDIAN #endif /* !_POSIX_SOURCE */ +#if defined(_KERNEL) +__uint32_t __htonl(__uint32_t __x); +__uint16_t __htons(__uint16_t __x); +__uint32_t __ntohl(__uint32_t __x); +__uint16_t __ntohs(__uint16_t __x); +#endif /* _KERNEL */ + #endif /* !_MACHINE_ENDIAN_H_ */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message