From owner-cvs-all@FreeBSD.ORG Wed Jul 7 22:41:44 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E610D16A4CE; Wed, 7 Jul 2004 22:41:44 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id A6BDC43D46; Wed, 7 Jul 2004 22:41:44 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-63-195-111-154.dsl.snfc21.pacbell.net [63.195.111.154]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i67Mfgrb024081 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 7 Jul 2004 15:41:43 -0700 Message-ID: <40EC7A5A.3010303@root.org> Date: Wed, 07 Jul 2004 15:34:02 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Warner Losh References: <20040707223539.6114C16A5B4@hub.freebsd.org> In-Reply-To: <20040707223539.6114C16A5B4@hub.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: [src] cvs commit: src/sys/dev/fdc fdc.c fdc_isa.c fdc_pccard.c fdcvar.h src/sys/modules/fdc Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2004 22:41:45 -0000 Warner Losh wrote: > imp 2004-07-07 22:35:27 UTC > > FreeBSD src repository > > Modified files: > sys/dev/fdc fdc.c > sys/modules/fdc Makefile > Added files: > sys/dev/fdc fdc_isa.c fdc_pccard.c fdcvar.h > Log: > Break out the isa and pccard front ends from fdc. This is the first > step in making this driver more attachment neutral. Others plan on > adding acpi front ends. > > Still need to cleanup the MI part of the driver because it isn't as > bus independent as it could be. > > Revision Changes Path > 1.276 +12 -304 src/sys/dev/fdc/fdc.c > 1.1 +145 -0 src/sys/dev/fdc/fdc_isa.c (new) > 1.1 +114 -0 src/sys/dev/fdc/fdc_pccard.c (new) > 1.1 +134 -0 src/sys/dev/fdc/fdcvar.h (new) > 1.9 +2 -14 src/sys/modules/fdc/Makefile I don't think you should put your copyright on code that is 100% from fdc.c. Bruce complained about this for my version of fdcvar.h. Also, you went the path of completely exposing the softc (and the requisite enum fields). In response to Bruce's comments, I had made major efforts to hide it and have accessor functions for the probe routines. This is why I didn't commit the acpi attachment a month ago (and still haven't committed it). I'm a little frustrated that it appears I could have gone with the exposed softc approach and saved quite a few hours of work. -Nate