From owner-dev-commits-src-main@freebsd.org Mon Feb 8 18:48:25 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 118AC53D481; Mon, 8 Feb 2021 18:48:25 +0000 (UTC) (envelope-from debdrup@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DZFQw73whz4fXQ; Mon, 8 Feb 2021 18:48:24 +0000 (UTC) (envelope-from debdrup@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612810105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6yjLKXXd0ltVlLnYcJUP66sypGlc7FG1H6CBSR7jads=; b=ZY3NwhUy5vAkq7WAnIVEYhrUlS2P6yVsiu+H1Pqw4/6N9DLqJmUy1JPAuypjTXpAmeEYqa rzfTlX/IOlIuw/GRmdUAwVGnOAwz/KjwyhaM1+75xQUh9bWG4DaxTLmQRgy2P1UqXAdAo4 mqG5EKiiyYDDfHVm1+gM18QQLGLT2J8aSh0pCFyG+O5/sLQtvFkNe4vVH6K3iLvMsC0Ss8 KZqYaeY9d+z7I4OPcwyP1WHw0w1URfzPGzyuft+aML5Oi38T+kpdVKLatDqK0raGcnlY2s YwiRM9TE91bH3JuTTbQROnbEg150nI6l1uJI1XnbPI7DR9NH0bJNfa+9y2k41A== Received: by freefall.freebsd.org (Postfix, from userid 1471) id DB9A75CAE; Mon, 8 Feb 2021 18:48:24 +0000 (UTC) Date: Mon, 8 Feb 2021 19:48:22 +0100 From: Daniel Ebdrup Jensen To: dev-commits-src-main@freebsd.org, "" Subject: Re: git: 866c8b8d5ddb - main - kldload(8): Add note about using kld_list in rc.conf(5) Message-ID: <20210208184822.uejqvgyl2ddv4emc@nerd-thinkpad.local> Mail-Followup-To: Daniel Ebdrup Jensen , dev-commits-src-main@freebsd.org, "" References: <202102080704.11874w7E017472@gitrepo.freebsd.org> <33d6f518-2005-e859-0230-34490c3c5914@grosbein.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ngewsruxf4hgc6kg" Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612810105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6yjLKXXd0ltVlLnYcJUP66sypGlc7FG1H6CBSR7jads=; b=dcDyDYsispaoSSvcNzYZJBVsmaDA5Hydh7/DE6pZGwqEuMMNSUPIS5z/9YE+Hi02EO8SRB KI/zIy+k8ziYXzKXE/3szUxGghgLHJCkHk/a6dnqSx6A8EtyDZNHh0yK2Qck1yig2mDZ/y 0R+ktCUhqLNzzhBM2c+Z2HVK2zj1UCPoZaolhOpWi5R0V+NdiZq+UNcfp/ZqRay63Vbctg Z58JmPK+LKXTmDWxbFEKhLurHcTIZdi2EXaVANTGT9xDl2UJAtoncUchGgOjPptXftdyPi Xjpbksb7wlm+d/Ru+Orgt5h1wyXkzjbCnHLeWfoaweqn8E4WWY2POaGnN5lEnw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1612810105; a=rsa-sha256; cv=none; b=nM8Bh14Zh5vzdFvZ/K1IZFDDPzZ4nj0GnDHrIo7qpJRx/id0Wp63iW/xTepKLLFc+m3ws5 yhDN+cEIcBenELHSmM+0Fg+lfNpa4sRVUD+W5/JjH7H+nsZlBHhG06qO00k/UjQEFsGG7S FWKcUcg79J7fqJGnV6wEUHB1kM4m4X6CyLSxUmOOOVH8NovUUlsT/pmBUCAK9nD9M4feVj 17/JR75KDBvS3YS1gXvLhtutXU+YpZe2LtK+QrPwFuy7y4lmtQ4fQPf4y+kZLlZI2T580R 3XEwYt3Cwptm6RYeQ+FatuNPcJDyiM4T6LRaTbI454F5dgVEX7OAtDTflvB3Jg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 18:48:25 -0000 --ngewsruxf4hgc6kg Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Mon, Feb 08, 2021 at 09:22:25AM -0600, Kyle Evans wrote: >On Mon, Feb 8, 2021 at 9:07 AM Eugene Grosbein wrote: >> >> 08.02.2021 21:58, Kyle Evans wrote: >> >> >>>> kld_list cannot do that. >> >>> >> >>> Huh? kld_list accepts a full pathname, which is the same kind of >> >>> specification you'd need to do with one from port in loader with >> >>> *_name. >> >> >> >> Good, but seems to be undocumented. >> >> >> > >> > In what sense? Is there some other place that kld_list is even >> > documented than kldload(8)? >> >> Naturally: rc.conf(5), also in /etc/defaults/rc.conf >> > >Wow, that documentation is just flat wrong for multiple reasons. > > kld_list (str) A whitespace-separated list of kernel modules to load > right after the local disks are mounted, without any .ko > extension or path. Loading modules at this point in the boot > process is much faster than doing it via /boot/loader.conf > for those modules not necessary for mounting local disks. > >The second part of the first sentence is a self-imposed limitation, >and an incredibly unimportant one at that. Specifying a .ko will only >break the existing "Is it loaded" behavior and cause it to always try, >which is mostly a nuisance at best because it will get rejected if the >kldstat inquiry is wrong -- the kld rc script will append .ko whether >the path has one or not, so this should be fixed. Despite that, a path >will work just fine for the most part; kldstat -v shows the fully >qualified path. If it wanted to be improved, it just needs to basename >what it was given to be able to detect if it was loaded from any other >path and pass that in as the -e argument to load_kld if it really was >a file. > >It's not wrong about loading modules being faster here, and at some >point in the past it was even necessary due to loader(8) being too >early or problematic in some terrible cases (e.g. nvidia modsetting >bits), but the second half of that sentence should probably just be >omitted or reworked to more vaguely refer to "... those modules not >necessary for booting the system, including those required for >mounting the root filesystem." The key changes being that there are >other reasons you might need to load something early enough in boot, >and that root isn't always a local disk. It's OK to call out the more >common case for folks, but this feels a lot more absolute than it >needs to be. >_______________________________________________ >dev-commits-src-main@freebsd.org mailing list >https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main >To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" Hi folks, I'd originally replied to imp@ when he sent me a comment about this, although because of a misconfiguration I hadn't seen it was also sent to a different list, but in it I remarked the same things about nvidia-modesetting and the speed, however I do think Kyle is right that it's better to rework the sentence because mountroot isn't really docuemented in the extant manual pages. I'm not sure about wanting to document the other details outlined here, because I'm not entirely sure I understand them - plus, it's in a different manual page, so it's free for anyone with an active commit bit and an understanding to persue. :) I'll try and work something out and do a Phabricator review, but let's try and keep the bike-shedding to a minimum. Yours, Daniel Ebdrup Jensen P.S. We all know the best colour is purple. ;) --ngewsruxf4hgc6kg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEDonNJPbg/JLIMoS6Ps5hSHzN87oFAmAhh3ZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDBF ODlDRDI0RjZFMEZDOTJDODMyODRCQTNFQ0U2MTQ4N0NDREYzQkEACgkQPs5hSHzN 87p7IAf+OFg52NNYY4KiYfajBDZ3W2suF/4XnEEmjEXK19kv8J76+IhmOZVloe6O uw1EF+p6Sd+vbmd/DMxUnxlFVI+kz8FhDse5Fqed3SWyEkqvjLzhO/qhQ9blNJ5S O9DLEJz8izUpwZvV/+zlLthqkP+zL/ezsy0qiEMsGRPv0n3kj8CkivpHIr0sGHAC DFN0xlV74CR1tCEBh6eJgPwrj61r1H1vJ82O4S0a1sQ/u4kSHg530Jsxu+MW4k5m kArGQDQ797b+KL90iVrpilJM0uchpntB5CjrIjA0B5Tq6on7cfbgtIvrd184P2uL POoAAffaZQXbmkwTmVYLi1NtJkMcWw== =fcdt -----END PGP SIGNATURE----- --ngewsruxf4hgc6kg--