From owner-cvs-all@FreeBSD.ORG  Thu Oct 23 01:08:49 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DECD016A4BF; Thu, 23 Oct 2003 01:08:49 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5C2BD43F85; Thu, 23 Oct 2003 01:08:47 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.9p2/8.12.9) with ESMTP id h9N88iE7048334;
	Thu, 23 Oct 2003 02:08:44 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 23 Oct 2003 02:05:39 -0600 (MDT)
Message-Id: <20031023.020539.126750350.imp@bsdimp.com>
To: des@des.no
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <xzp8yncgz3v.fsf@dwp.des.no>
References: <xzpfzhkh10t.fsf@dwp.des.no>
	<20031023.013423.02875687.imp@bsdimp.com>
	<xzp8yncgz3v.fsf@dwp.des.no>
X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: nate@root.org
Subject: Re: cvs commit: src/sys/dev/ep if_ep.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Oct 2003 08:08:50 -0000

In message: <xzp8yncgz3v.fsf@dwp.des.no>
            des@des.no (Dag-Erling Sm=F8rgrav) writes:
: "M. Warner Losh" <imp@bsdimp.com> writes:
: > des@des.no (Dag-Erling Sm=F8rgrav) writes:
: > > caddr_t is never right.  If it's a character pointer, use char *.=

: > Why not?  The rest of the driver uses it heavily, and the data type=
 of
: > the underlying mbufs is caddr_t:
: =

: Because the intention behind caddr_t was to be a "poor man's void *".=

: When used as "void *" it is patently wrong, and when used as "char *"=

: it is simply needless, unportable, obfuscating baggage.  If you mean
: "char *", you should write "char *".

I'll keep that in mind.  caddr_t stays for now because I have lots of
other changes to ep I don't want to pollute with a change like that.
There are two fewer caddr_t in ep than there were a few weeks ago,
instead of 4 after the partial reversion.

So caddr_t is right here because the rest of the driver uses it.
Until someone goes through and converts the driver and the network, it
will be the least wrong type to use.  Long term you are right, but
short term it's not going to change.

Warner