From nobody Thu Apr 24 23:00:18 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZkBJk1Z3xz5tttK for ; Thu, 24 Apr 2025 23:00:22 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZkBJj6Dcsz3Mk1 for ; Thu, 24 Apr 2025 23:00:21 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-861525e9b0aso134543639f.3 for ; Thu, 24 Apr 2025 16:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1745535619; x=1746140419; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fU8j9RnmbcpGWGBNe0GES3CRSuKpwCerpzY2D6r2W5w=; b=X3SGI1E2wxASGN3NNvvF4TobhZoShuUhmEvHCgmagnq7AdRkQChpO1+aqUARKg0Hy8 a59TIen3VpFzmqDrOc0CX9iXKOmCzwkag3g9kHCLMIj79PPDCglc6/p0yDudxH83k64V UPKtxS0Cq7B10XfpVAs3OrBCYY2AqWICZlU+39IsNfgTaOmJ+FsZwpDs/LRhU2o+Vdcb luEikPtCm1GCpu4x8ZVGDRIpgtp+Y52B+AbazEzrdGJcyjd/bHutYW9kxdJk4htzEz1+ v6fGcOVBnf7C+LJQuBTLDFRdtL0JNnkiLKMmyOiIhT9e1lsaBaqabJSL2j/AkZdcJvSH OikQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745535619; x=1746140419; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fU8j9RnmbcpGWGBNe0GES3CRSuKpwCerpzY2D6r2W5w=; b=lEA1s1ge80pcrZc5CM98yHwNLUXfSIj+6Tdpqxizi8CaUEhdaRfqJMcNKUKJGrbYSU QdtzCBYr+RPqiHT88ffLCel/9ezIP7OcmNtHmiUm6BUbal46vXgmtjbdpeRjrVcB4ffs udLXg1UTjiofnqn1EHjkhpKqQ1d6lQM66ysODPpt/nzCknL1aB+FHCVwMW9IAxrsUy0K VAqgmCRXr7zSGoUtZ3JBg1fW7deYUtHhKGcoVHZyPcQ9NOoZ3HIuO+x8JNMlCdvhXH71 DDLrBoPwBAIbwBbZPGrVQmrpMxXJdaPTeD27nc7I0+XVj3Pcp7AktWIGCxoxKLNYzp5E sPkQ== X-Forwarded-Encrypted: i=1; AJvYcCV09FNh7Oe30k3LCAuVzAQqoy/jyMFXbRahg431D1frmI7P+lbCFEnFuDjaOCD4fW7PtiFMEJuc8Xu+PLjpvjctfnCN@freebsd.org X-Gm-Message-State: AOJu0Yxwccjz4s+6g7LlcqDyAX8X25BxPfLG6awi+yVoeM6VUzDaU4Kp wiGBeOjnU1O/Vz70JfcRmdtaUK88fLeQW5qYw/JJqImdrnkQW+ouNuB88pj3uRY= X-Gm-Gg: ASbGnctn/+1AsjIjTRh/fIHKp0cvAnmydr2AvX+std7embM/uM3jnttWPg2m3Ee7spF WOHB7yA8sA/YUmn46yTp6oCS4AYokSsiFXHz56ZcqAXwGsZPy+olg4oPwv/NAG1uqtdqLfBlDHB OrqKGQgSZZv5l2fwkFZIfTJDeCQ6mD92g/JZLa2JAaieohewKeff56KT5QDkobUR/4gvj0ZPE6k bBfG/D0ruxuI7xqftLpNoeikq+bg0paa/R5G9hBwI85CS0JTZ/FRAzuthqjl1l2LDlN0ER/BxsI eNrlsr5rvggrwuepVv3CYdE= X-Google-Smtp-Source: AGHT+IFw53BAgs/AJ+1aO0+boDkb/KOY/GTh4UrTKTB4fXbSKxrI7sEfX4AufQUuabUQn7CvydFAIA== X-Received: by 2002:a05:6602:6089:b0:864:47e6:23ce with SMTP id ca18e2360f4ac-8645d1748e4mr22939339f.4.1745535619524; Thu, 24 Apr 2025 16:00:19 -0700 (PDT) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f824b85596sm475300173.80.2025.04.24.16.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 16:00:18 -0700 (PDT) Date: Thu, 24 Apr 2025 23:00:18 +0000 From: Shawn Webb To: Jessica Clarke Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a098111a28ed - main - secure: Add ssh-sk-client to all consumers of libssh Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.2-STABLE-HBSD FreeBSD 14.2-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202504220207.53M27okn077850@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="awq4bouiw4c2uwed" Content-Disposition: inline In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4ZkBJj6Dcsz3Mk1 X-Spamd-Bar: ---- --awq4bouiw4c2uwed Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: a098111a28ed - main - secure: Add ssh-sk-client to all consumers of libssh MIME-Version: 1.0 On Thu, Apr 24, 2025 at 11:56:03PM +0100, Jessica Clarke wrote: > On 24 Apr 2025, at 23:45, Shawn Webb wrote: > > On Tue, Apr 22, 2025 at 02:07:50AM +0000, John Baldwin wrote: > >> The branch main has been updated by jhb: > >>=20 > >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da098111a28ed59e1ab1101a= d09913f0235ebd28f > >>=20 > >> commit a098111a28ed59e1ab1101ad09913f0235ebd28f > >> Author: John Baldwin > >> AuthorDate: 2025-04-22 02:05:28 +0000 > >> Commit: John Baldwin > >> CommitDate: 2025-04-22 02:05:28 +0000 > >>=20 > >> secure: Add ssh-sk-client to all consumers of libssh > >>=20 > >> These all failed to link with ld.bfd used by GCC due to > >> Fssh_sshsk_sign being an unresolved symbol. > >>=20 > >> Fixes: 65d8491719bb ("secure: Adapt Makefile to ssh-sk-cli= ent everywhere") > >=20 > > Hey John, > >=20 > > I'm getting the following error from the RTLD when the rc scripts > > start sshd: > >=20 > > =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > > ld-elf.so.1: /usr/lib/libprivatessh.so.5: Undefined symbol "Fssh_sshsk_= sign > > =3D=3D=3D=3D END LOG =3D=3D=3D=3D > >=20 > > This is on HardenedBSD 15-CURRENT/amd64. I'll try to reproduce next > > week with vanilla FreeBSD, unless someone else beats me to it. >=20 > I don=E2=80=99t understand how this is meant to work. sshsk_sign is used = by > sshkey.c, which is in libssh, so why are we putting the definition of > sshsk_sign (namespaced) in each and every program? I'm not sure. Looking more closely at this commit and the commit referenced on the Fixes: line, I'm wondering if the use of $() is valid instead of ${}. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --awq4bouiw4c2uwed Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmgKwnsACgkQ/y5nonf4 4fro3xAAi2AWJIwo4z6A3H/fWfop/nh8RaV9OVLtoGp1S9Kucq+UQwofWlF7lB5G +y9YJpxQpoFQmO5PVWOn9J/oFPUIbmHy1Th8SXdgE082AmTpIbreoSJkbeXGGRTd boFI7Fb+8jrofRks7d0/N5IM5APB6U/D3fQYXeoWYFEL6PDMhN2nUXX7kIn1qQ+Y W0iBhp/apYXI8A8jffPLZyz4vYNNkVblGTbZAcuX7UcX64LPe4nzN/Osf11Wc8DZ fFNU4mME1imBKwoX+9Ayk7rWiszK3LVHYNtjOUaDoxcvVU37NqAaYkxXK0tLLONk H33PMWUVKV5CWyFBg33RVTbiH+3sNEH/Wi1OIez735B0xUtTVIbXrJlAEBKavR/c 9qUcQY0RepmeWixCv+Loj2CHQiAQ9unPeKFxPczmAeR0mEaYksbsa5yePDxeLgUI 9KrQF94iiINhr6Cypr1M0t5THUwQElaH0bpxNCDIWk833h+1Bns9zj8KOP6+c+GP XydgsHo79sw/mdJAyvC+lilWZ/lNF5wx94sRxYyIPPtWYCnlY1MMzdaCHTSprnty QYddjnvz2I+bIxLI4gd6AfEBS+Azfs3w26HtY9AT4mAnC3axnhYuO28KwJ1yup8k qutfBID4PqHW5VUhJmZoeqBIrTJITx4T/ifg3G5AGuJN45h3aVg= =3vLm -----END PGP SIGNATURE----- --awq4bouiw4c2uwed--