From owner-svn-ports-head@freebsd.org Wed Jan 18 11:53:58 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85615CB51ED; Wed, 18 Jan 2017 11:53:58 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3B2E11C32; Wed, 18 Jan 2017 11:53:58 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v0IBrvpv007630; Wed, 18 Jan 2017 11:53:57 GMT (envelope-from jbeich@FreeBSD.org) Received: (from jbeich@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v0IBrvdT007627; Wed, 18 Jan 2017 11:53:57 GMT (envelope-from jbeich@FreeBSD.org) Message-Id: <201701181153.v0IBrvdT007627@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jbeich set sender to jbeich@FreeBSD.org using -f From: Jan Beich Date: Wed, 18 Jan 2017 11:53:57 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r431792 - in head/devel/qt4-linguist: . files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 11:53:58 -0000 Author: jbeich Date: Wed Jan 18 11:53:56 2017 New Revision: 431792 URL: https://svnweb.freebsd.org/changeset/ports/431792 Log: devel/qt4-linguist: unbreak with clang 4.0 messagemodel.cpp:186:61: error: ordered comparison between pointer and zero ('MessageItem *' and 'int') if (c->findMessage(m->text(), m->comment()) >= 0) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~ PR: 216051 Submitted by: Adriaan de Groot Obtained from: upstream (Qt5) Approved by: kde (tcberner) MFH: 2017Q1 (changes behavior) Differential Revision: https://reviews.freebsd.org/D9184 Added: head/devel/qt4-linguist/files/patch-tools_linguist_linguist_messagemodel.cpp (contents, props changed) Modified: head/devel/qt4-linguist/Makefile (contents, props changed) Modified: head/devel/qt4-linguist/Makefile ============================================================================== --- head/devel/qt4-linguist/Makefile Wed Jan 18 11:40:35 2017 (r431791) +++ head/devel/qt4-linguist/Makefile Wed Jan 18 11:53:56 2017 (r431792) @@ -3,6 +3,7 @@ PORTNAME= linguist DISTVERSION= ${QT4_VERSION} +PORTREVISION= 1 CATEGORIES= devel PKGNAMEPREFIX= qt4- Added: head/devel/qt4-linguist/files/patch-tools_linguist_linguist_messagemodel.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/qt4-linguist/files/patch-tools_linguist_linguist_messagemodel.cpp Wed Jan 18 11:53:56 2017 (r431792) @@ -0,0 +1,14 @@ +Fix bogus pointer comparison. Backport of upstream commit +https://github.com/qt/qttools/commit/7138c963f9d1258bc1b49cb4d63c3e2b7d0ccfda + +--- tools/linguist/linguist/messagemodel.cpp.orig 2015-05-07 14:14:39 UTC ++++ tools/linguist/linguist/messagemodel.cpp +@@ -183,7 +183,7 @@ static int calcMergeScore(const DataMode + if (ContextItem *c = one->findContext(oc->context())) { + for (int j = 0; j < oc->messageCount(); ++j) { + MessageItem *m = oc->messageItem(j); +- if (c->findMessage(m->text(), m->comment()) >= 0) ++ if (c->findMessage(m->text(), m->comment())) + ++inBoth; + } + }