From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 21:11:36 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA122895; Thu, 23 Jan 2014 21:11:35 +0000 (UTC) Received: from mail-wg0-x235.google.com (mail-wg0-x235.google.com [IPv6:2a00:1450:400c:c00::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4A0861C7A; Thu, 23 Jan 2014 21:11:35 +0000 (UTC) Received: by mail-wg0-f53.google.com with SMTP id y10so2163878wgg.20 for ; Thu, 23 Jan 2014 13:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=aTU/MFqrhWPT6m4dvRGL3K3xGyye1tv+y3mTSVdW5lM=; b=Ehvf5oCLmFkoaJLY+ZmJHvGjnRnksnTM86kjOU17wNBLeDEHwXnsGnZiG2EQlNJfv+ h8K99aufgP7Y+0Y+PTpe5VIsf9jjeTMOSbJG3JPvl52VUCsBB4TrD1gYKe35vD2/PbM/ bTB0L16XQYweV0nXYkXK58pC3BS8kWKWv2BLCaGEknY6xptjEND+YkY7lMgaaKn8rawQ bKXeR4sNL+r+kO53VcNPpW2nPffOcULDspK4v6PTNRpaF11exsSpJ7RKEEC+5cHsohkc NwOqbpDJpeWaEag7dwfbhFf3CpQ2wYfSfj1qdJ+e32c9QnqyIdvCMpDhLnxyWYAV9fK/ vvOg== MIME-Version: 1.0 X-Received: by 10.194.185.113 with SMTP id fb17mr8059686wjc.29.1390511493757; Thu, 23 Jan 2014 13:11:33 -0800 (PST) Sender: asomers@gmail.com Received: by 10.194.22.35 with HTTP; Thu, 23 Jan 2014 13:11:33 -0800 (PST) In-Reply-To: References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> Date: Thu, 23 Jan 2014 14:11:33 -0700 X-Google-Sender-Auth: UPrc9n1p3L3QuZ-x1k1KsYXJZ4Q Message-ID: Subject: Re: Makefile.inc1.patch From: Alan Somers To: Garrett Cooper Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-testing@freebsd.org" , "Simon J. Gerraty" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 21:11:36 -0000 On Thu, Jan 23, 2014 at 2:00 PM, Garrett Cooper wro= te: > On Jan 23, 2014, at 12:56 PM, Alan Somers wrote: > >> On Thu, Jan 23, 2014 at 1:53 PM, Garrett Cooper = wrote: >>> On Jan 22, 2014, at 8:34 AM, Garrett Cooper wro= te: >>> >>>> >>>>> On Jan 22, 2014, at 7:42, Alan Somers wrote: >>>>> >>>>>> On Tue, Jan 21, 2014 at 3:17 PM, Garrett Cooper wrote: >>>>>> Hi all, >>>>>> The attached patch fixes/enhances the build so -DNO_TESTS is passed= properly through various sections of the build that don't require tests in= order to build/install. This should also fix Alan's recent reported issue = with -DWITH_TESTS failing on amd64. >>>>>> Cheers! >>>>>> -Garrett >>>>> >>>>> The patch doesn't work for me. I get the following error during >>>>> buildworld during stage 4.4. >>>> >>>> ... >>>> >>>> Oh yeah... It's that chicken and egg issue due to ATF now being contro= lled by MK_TESTS=3D=3Dyes... There's more to this patch I need to provide y= ou in order for things to work... >>> >>> Here=92s the working patch. The difference between this one and = the prior version is that you have to explicitly override -DNO_TESTS when b= uilding lib/atf* (Simon: do you have any comments?): >>> >>> -.if ${MK_TESTS} !=3D "no" >>> +.if defined(WITH_ATF) || ${MK_TESTS} !=3D "no" >>> +# Make sure WITH_ATF overrules -DNO_TESTS >>> +.if !defined(WITH_ATF) >>> +MAKE+=3D -DWITH_ATF >>> +.endif >>> >>> I unrolled most of the local changes to Makefile.inc1 on my gith= ub fork so it=92ll be easier to spot if you diff it against my tree. >>> Thanks! >>> -Garrett >> >> Shouldn't that be "WITH_TESTS" instead of "WITH_ATF"? Those options >> got combined awhile back. > > Unfortunately no. The chicken and the egg problem I ran into is l= ike so: > 1. make libraries shouldn=92t build tests (in particular it will bomb if = it tries to build something that needs to link against libatf*.so). This is= n=92t a problem today, but will become a problem when lib/libc/tests is pus= hed back to FreeBSD. > 2. lib/atf needs to be installed sooner so atf-check, etc link properly. > This wasn=92t a chicken and egg problem until the two knobs were = merged=85 > Thanks! > -Garrett In that case, I'm missing something. I can't find any makefiles that reference MK_ATF or a related variable. What is the effect of setting WITH_ATF ? -Alan