Date: Tue, 8 Feb 2022 02:04:19 +0300 From: Mehmet Erol Sanliturk <m.e.sanliturk@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, Sebastian Huber <sebastian.huber@embedded-brains.de>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: ntp_init() looks like a nop Message-ID: <CAOgwaMvMTUro_MXL4411ArmXCR0x2eMO7v9ToLPg5kA5G22GNA@mail.gmail.com> In-Reply-To: <CANCZdfppnS-zpMJa2u%2BWtgzBxh4XqTRGDaEJKJVeOPZNJWotGw@mail.gmail.com> References: <ac806cf6-a17f-77ba-5633-0c95eda1f8cf@embedded-brains.de> <202202072032.217KWUdU085792@critter.freebsd.dk> <CANCZdfppnS-zpMJa2u%2BWtgzBxh4XqTRGDaEJKJVeOPZNJWotGw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Feb 8, 2022 at 12:33 AM Warner Losh <imp@bsdimp.com> wrote: > > > On Mon, Feb 7, 2022 at 1:34 PM Poul-Henning Kamp <phk@phk.freebsd.dk> > wrote: > >> -------- >> Sebastian Huber writes: >> >> > The ntp_init() function sets a couple of global variables to zero. >> These=20 >> > variables should be in the .bss section. Are they not already cleared=20 >> > during the kernel loading? >> >> They are, but I kept the code to minimize the diff relative to Dave Mills >> original version of the code. >> >> It can go no. >> > > I think I lost the email race. I just pushed Sebastian's changes. Is this > a request to not do this? If so, I'll revert. > > Warner > My reply is not an answer to your question , but I want to make a remark . I am developing a software about "A multi-media information management system" ( a continuation of my PhD thesis demonstration program ) having around 12 000 Pascal procedures . For "Record"-s , I am doing the following : By using a script system , I am generating many Procedures about operations on that "Record" , such as : (1) Allocate (2) Initialize (3) ... (n) Dispose In your case , it is said that "in another part this record is initialized ..." Assume that , "another part" is modified to ignore this initialization , and there is not a call to an initializer . In Turkish , this is called "To load a liver to a cat" ( I am sorry to say that ) . To prevent such disastrous possibilities ( after losing significant times to understand what is the reason ) I have developed such an approach . My ideas are like that . Obviously you know much better than me how to develop FreeBSD . With my best wishes , Mehmet Erol Sanliturk [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:large"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 8, 2022 at 12:33 AM Warner Losh <<a href="mailto:imp@bsdimp.com">imp@bsdimp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 7, 2022 at 1:34 PM Poul-Henning Kamp <<a href="mailto:phk@phk.freebsd.dk" target="_blank">phk@phk.freebsd.dk</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">--------<br> Sebastian Huber writes:<br> <br> > The ntp_init() function sets a couple of global variables to zero. These=20<br> > variables should be in the .bss section. Are they not already cleared=20<br> > during the kernel loading?<br> <br> They are, but I kept the code to minimize the diff relative to Dave Mills<br> original version of the code.<br> <br> It can go no.<br></blockquote><div><br></div><div>I think I lost the email race. I just pushed Sebastian's changes. Is this a request to not do this? If so, I'll revert.</div><div><br></div><div>Warner </div></div></div></blockquote><div><br></div><div><br></div><div><br></div><div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">My reply is not an answer to your question , but I want to make a remark .</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">I am developing a software about "A multi-media information management system"</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">( a continuation of my PhD thesis demonstration program ) having around 12 000</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">Pascal procedures .</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">For "Record"-s , I am doing the following :</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">By using a script system , I am generating many Procedures about operations on that</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">"Record" , such as :</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">(1) Allocate</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">(2) Initialize <br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">(3) ...<br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">(n) Dispose<br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">In your case , it is said that "in another part this record is initialized ..."</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">Assume that , "another part" is modified to ignore this initialization , and there is not</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">a call to an initializer . <br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">In Turkish , this is called "To load a liver to a cat" ( I am sorry to say that ) .</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">To prevent such disastrous possibilities ( after losing significant times to understand <br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">what is the reason ) I have developed such an approach .</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">My ideas are like that .</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">Obviously you know much better than me how to develop FreeBSD .<br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">With my best wishes ,</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default">Mehmet Erol Sanliturk</div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;font-size:large" class="gmail_default"></div><br></div><div><br></div><div> </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOgwaMvMTUro_MXL4411ArmXCR0x2eMO7v9ToLPg5kA5G22GNA>