Date: Tue, 8 Feb 2022 02:04:19 +0300 From: Mehmet Erol Sanliturk <m.e.sanliturk@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, Sebastian Huber <sebastian.huber@embedded-brains.de>, FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: ntp_init() looks like a nop Message-ID: <CAOgwaMvMTUro_MXL4411ArmXCR0x2eMO7v9ToLPg5kA5G22GNA@mail.gmail.com> In-Reply-To: <CANCZdfppnS-zpMJa2u%2BWtgzBxh4XqTRGDaEJKJVeOPZNJWotGw@mail.gmail.com> References: <ac806cf6-a17f-77ba-5633-0c95eda1f8cf@embedded-brains.de> <202202072032.217KWUdU085792@critter.freebsd.dk> <CANCZdfppnS-zpMJa2u%2BWtgzBxh4XqTRGDaEJKJVeOPZNJWotGw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000027cbc05d775a146 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 8, 2022 at 12:33 AM Warner Losh <imp@bsdimp.com> wrote: > > > On Mon, Feb 7, 2022 at 1:34 PM Poul-Henning Kamp <phk@phk.freebsd.dk> > wrote: > >> -------- >> Sebastian Huber writes: >> >> > The ntp_init() function sets a couple of global variables to zero. >> These=20 >> > variables should be in the .bss section. Are they not already cleared=20 >> > during the kernel loading? >> >> They are, but I kept the code to minimize the diff relative to Dave Mills >> original version of the code. >> >> It can go no. >> > > I think I lost the email race. I just pushed Sebastian's changes. Is this > a request to not do this? If so, I'll revert. > > Warner > My reply is not an answer to your question , but I want to make a remark . I am developing a software about "A multi-media information management system" ( a continuation of my PhD thesis demonstration program ) having around 12 000 Pascal procedures . For "Record"-s , I am doing the following : By using a script system , I am generating many Procedures about operations on that "Record" , such as : (1) Allocate (2) Initialize (3) ... (n) Dispose In your case , it is said that "in another part this record is initialized ..." Assume that , "another part" is modified to ignore this initialization , and there is not a call to an initializer . In Turkish , this is called "To load a liver to a cat" ( I am sorry to say that ) . To prevent such disastrous possibilities ( after losing significant times to understand what is the reason ) I have developed such an approach . My ideas are like that . Obviously you know much better than me how to develop FreeBSD . With my best wishes , Mehmet Erol Sanliturk --000000000000027cbc05d775a146 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:tahoma,sans-serif;font-size:large"><br></div></div><br><div class= =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Feb 8, 2022 = at 12:33 AM Warner Losh <<a href=3D"mailto:imp@bsdimp.com">imp@bsdimp.co= m</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin= :0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"= ><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote"= ><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Feb 7, 2022 at 1:34 PM Poul-= Henning Kamp <<a href=3D"mailto:phk@phk.freebsd.dk" target=3D"_blank">ph= k@phk.freebsd.dk</a>> wrote:<br></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa= dding-left:1ex">--------<br> Sebastian Huber writes:<br> <br> > The ntp_init() function sets a couple of global variables to zero. The= se=3D20<br> > variables should be in the .bss section. Are they not already cleared= =3D20<br> > during the kernel loading?<br> <br> They are, but I kept the code to minimize the diff relative to Dave Mills<b= r> original version of the code.<br> <br> It can go no.<br></blockquote><div><br></div><div>I think I lost the email = race. I just pushed Sebastian's changes. Is this a request to not do th= is? If so, I'll revert.</div><div><br></div><div>Warner=C2=A0</div></di= v></div></blockquote><div><br></div><div><br></div><div><br></div><div><div= style=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_def= ault">My reply is not an answer to your question , but I want to make a rem= ark .</div><div style=3D"font-family:tahoma,sans-serif;font-size:large" cla= ss=3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-serif;= font-size:large" class=3D"gmail_default"><br></div><div style=3D"font-famil= y:tahoma,sans-serif;font-size:large" class=3D"gmail_default">I am developin= g a software about "A multi-media information management system"<= /div><div style=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"= gmail_default">( a continuation of my PhD thesis demonstration program ) ha= ving around=C2=A0 12 000</div><div style=3D"font-family:tahoma,sans-serif;f= ont-size:large" class=3D"gmail_default">Pascal procedures .</div><div style= =3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_default">= <br></div><div style=3D"font-family:tahoma,sans-serif;font-size:large" clas= s=3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-serif;f= ont-size:large" class=3D"gmail_default">For=C2=A0 "Record"-s , I = am doing the following :</div><div style=3D"font-family:tahoma,sans-serif;f= ont-size:large" class=3D"gmail_default"><br></div><div style=3D"font-family= :tahoma,sans-serif;font-size:large" class=3D"gmail_default">By using a scri= pt system , I am generating many Procedures =C2=A0 about=C2=A0 operations o= n that</div><div style=3D"font-family:tahoma,sans-serif;font-size:large" cl= ass=3D"gmail_default">"Record" , such as :</div><div style=3D"fon= t-family:tahoma,sans-serif;font-size:large" class=3D"gmail_default">(1) All= ocate</div><div style=3D"font-family:tahoma,sans-serif;font-size:large" cla= ss=3D"gmail_default">(2) Initialize <br></div><div style=3D"font-family:tah= oma,sans-serif;font-size:large" class=3D"gmail_default">(3) ...<br></div><d= iv style=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_d= efault"><br></div><div style=3D"font-family:tahoma,sans-serif;font-size:lar= ge" class=3D"gmail_default">(n) Dispose<br></div><div style=3D"font-family:= tahoma,sans-serif;font-size:large" class=3D"gmail_default"><br></div><div s= tyle=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_defau= lt"><br></div><div style=3D"font-family:tahoma,sans-serif;font-size:large" = class=3D"gmail_default">In your case , it is said that "in another par= t this record is initialized ..."</div><div style=3D"font-family:tahom= a,sans-serif;font-size:large" class=3D"gmail_default"><br></div><div style= =3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_default">= Assume that ,=C2=A0=C2=A0 "another part" is modified to ignore th= is initialization , and there is not</div><div style=3D"font-family:tahoma,= sans-serif;font-size:large" class=3D"gmail_default">a call to=C2=A0 an init= ializer .=C2=A0 <br></div><div style=3D"font-family:tahoma,sans-serif;font-= size:large" class=3D"gmail_default"><br></div><div style=3D"font-family:tah= oma,sans-serif;font-size:large" class=3D"gmail_default">In Turkish , this i= s called "To load a liver to a cat"=C2=A0 ( I am sorry to say tha= t ) .</div><div style=3D"font-family:tahoma,sans-serif;font-size:large" cla= ss=3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-serif;= font-size:large" class=3D"gmail_default">To prevent such disastrous possibi= lities ( after losing significant times to understand <br></div><div style= =3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_default">= what is the reason ) I have developed such an approach .</div><div style=3D= "font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_default"><br= ></div><div style=3D"font-family:tahoma,sans-serif;font-size:large" class= =3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-serif;fo= nt-size:large" class=3D"gmail_default">My ideas are like that .</div><div s= tyle=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_defau= lt"><br></div><div style=3D"font-family:tahoma,sans-serif;font-size:large" = class=3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-ser= if;font-size:large" class=3D"gmail_default"><br></div><div style=3D"font-fa= mily:tahoma,sans-serif;font-size:large" class=3D"gmail_default">Obviously y= ou know much better than me how to develop FreeBSD .<br></div><div style=3D= "font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_default"><br= ></div><div style=3D"font-family:tahoma,sans-serif;font-size:large" class= =3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-serif;fo= nt-size:large" class=3D"gmail_default">With my best wishes ,</div><div styl= e=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_default"= ><br></div><div style=3D"font-family:tahoma,sans-serif;font-size:large" cla= ss=3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-serif;= font-size:large" class=3D"gmail_default">Mehmet Erol Sanliturk</div><div st= yle=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_defaul= t"><br></div><div style=3D"font-family:tahoma,sans-serif;font-size:large" c= lass=3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans-seri= f;font-size:large" class=3D"gmail_default"><br></div><div style=3D"font-fam= ily:tahoma,sans-serif;font-size:large" class=3D"gmail_default"><br></div><d= iv style=3D"font-family:tahoma,sans-serif;font-size:large" class=3D"gmail_d= efault"><br></div><div style=3D"font-family:tahoma,sans-serif;font-size:lar= ge" class=3D"gmail_default"><br></div><div style=3D"font-family:tahoma,sans= -serif;font-size:large" class=3D"gmail_default"></div><br></div><div><br></= div><div>=C2=A0</div></div></div> --000000000000027cbc05d775a146--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOgwaMvMTUro_MXL4411ArmXCR0x2eMO7v9ToLPg5kA5G22GNA>