From owner-freebsd-net@FreeBSD.ORG Mon Jun 7 07:53:17 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EC2A16A4CE for ; Mon, 7 Jun 2004 07:53:17 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id A53E043D1F for ; Mon, 7 Jun 2004 07:53:16 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i577xHCG098896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Jun 2004 10:59:18 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.12.11/8.12.11) id i577qwuM000680; Mon, 7 Jun 2004 10:52:58 +0300 (EEST) (envelope-from ru) Date: Mon, 7 Jun 2004 10:52:58 +0300 From: Ruslan Ermilov To: Gleb Smirnoff Message-ID: <20040607075258.GA642@ip.net.ua> References: <20040607071701.GC17986@cell.sick.ru> <20040607073812.GA339@ip.net.ua> <20040607074410.GC18232@cell.sick.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <20040607074410.GC18232@cell.sick.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: Julian Elischer cc: net@FreeBSD.org Subject: Re: HEADSUP! netgraph Metadata changing. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 07:53:17 -0000 --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2004 at 11:44:10AM +0400, Gleb Smirnoff wrote: > On Mon, Jun 07, 2004 at 10:38:12AM +0300, Ruslan Ermilov wrote: > R> On Mon, Jun 07, 2004 at 11:17:01AM +0400, Gleb Smirnoff wrote: > R> > On Sun, Jun 06, 2004 at 06:35:51PM -0700, Julian Elischer wrote: > R> > J> In addition the ng_ksocket node adds info into metadata and I sus= pect > R> > J> there are people using that. > R> >=20 > R> > Since ng_ksocket tags packets for itself only, we can safely change = it. > R> >=20 > R> I use this feature in one proprietary module (need to send/recevive > R> UDP datagrams to/from different destinations). >=20 > Does your module reads/writes meta? >=20 It does, in its "rcvdata" method: NG_FREE_META(meta); len =3D sizeof(*meta) + sizeof(*mhead) + sizeof(*sin); MALLOC(meta, meta_p, len, M_NETGRAPH, M_NOWAIT | M_ZERO); if (meta =3D=3D NULL) { NG_FREE_M(m); return (ENOMEM); } ... Yes, the change will break it. No, I'm not opposed to a change. I was just commenting on the "for itself" bit, it's not true. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAxB7aqRfpzJluFF4RAm8fAJ9L/Iyt+NzOiwDQ7JJDBr1LtajPJwCcDxt9 +nFN+L2atAGZV2RgYiFG96U= =1Ivc -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--