From nobody Tue Jan 24 17:22:30 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P1Yh56VRZz3b2K2; Tue, 24 Jan 2023 17:22:45 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P1Yh50hnMz3Qsd; Tue, 24 Jan 2023 17:22:45 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of adrian.chadd@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=adrian.chadd@gmail.com; dmarc=none Received: by mail-lf1-f54.google.com with SMTP id o20so24544237lfk.5; Tue, 24 Jan 2023 09:22:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=byKP/t4mVffmP5tzaaciNKJy71wZQLEcawzDzhGV8jU=; b=VV4x9FAAOehAKLRoTv4K8vsOU5bdByHkJWph5lVHiQEaIz7aKIiFZhYp1nOo61hJ/x 3RHNGc3PFMAy3vduHTxW/Z87PnBDpu9EM/zBiX18GE2M+gNVW4OfWphCiByBoWCW93lP XFPjAM9vMCVW44OlsYisSQuOs0nfDkvhon49YuSAlo0QGW0eevfWSfMSlLO9j8ePLvWq rkRha7YtrZGbZMINzPdYXjfHQXebtcAnnV61xB6jnV36DHL52URBiraBE5BBiXe+inTV JHEtIV6/Ynf4YVUH3mDXByiRy7PXfg+KjWhKdKAGaz4JkYtRqBf+V2MM/+wg2Hjab4v1 YkSg== X-Gm-Message-State: AFqh2koa4KDB9e+qfRLFL3klCvVorHaOp7NN9ilGUwZimOm6a+37TuD3 yqlltybgG7aBAIAxwHP5A8+iCddfEYL1H29kC6LZ1zv7 X-Google-Smtp-Source: AMrXdXt01Yi2mUiYg6i4p/OYt0yTi9+Zzj+L+W/5JPk1YaWC/aUPeBq/0Ukr1Q138zvJxt77ZtvyTmx0kkK/7wwPywc= X-Received: by 2002:a19:5502:0:b0:4a2:4b01:8466 with SMTP id n2-20020a195502000000b004a24b018466mr2115254lfe.34.1674580961920; Tue, 24 Jan 2023 09:22:41 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202301210443.30L4hnw4015211@gitrepo.freebsd.org> In-Reply-To: From: Adrian Chadd Date: Tue, 24 Jan 2023 09:22:30 -0800 Message-ID: Subject: Re: git: ffc58e2ca365 - main - asmc: Add MacbookAir6,2 To: jrtc27@freebsd.org Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000620ac005f305c38e" X-Spamd-Result: default: False [-2.96 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.96)[-0.962]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.54:from]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.54:from]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; ARC_NA(0.00)[]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4P1Yh50hnMz3Qsd X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000620ac005f305c38e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable yeah i meant markj, but i was sick and tired and somehow my brain crossed streams. sorry! -a On Fri, 20 Jan 2023 at 21:55, Jessica Clarke wrote: > On 21 Jan 2023, at 04:43, Adrian Chadd wrote: > > > > The branch main has been updated by adrian: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dffc58e2ca36546d866bb6bd36a3aa8f= 762a01663 > > > > commit ffc58e2ca36546d866bb6bd36a3aa8f762a01663 > > Author: Adrian Chadd > > AuthorDate: 2023-01-21 04:34:31 +0000 > > Commit: Adrian Chadd > > CommitDate: 2023-01-21 04:34:31 +0000 > > > > asmc: Add MacbookAir6,2 > > > > Add in the zones for my MacbookAir6,2, a 2013 Macbook Air. > > > > Tested - said Macbook Air 2013. Thermal Zones and keyboard backligh= t > > control works fine. > > > > Differential Revision: https://reviews.freebsd.org/D38073 > > Approved by: jrtc27 > > Uh this is the first I=E2=80=99m hearing of this patch? > > Jess > > > --- > > sys/dev/asmc/asmc.c | 9 +++++++-- > > sys/dev/asmc/asmcvar.h | 25 +++++++++++++++++++++++++ > > 2 files changed, 32 insertions(+), 2 deletions(-) > > > > diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c > > index bec0054e2dd7..337f641e4513 100644 > > --- a/sys/dev/asmc/asmc.c > > +++ b/sys/dev/asmc/asmc.c > > @@ -427,7 +427,13 @@ static const struct asmc_model asmc_models[] =3D { > > ASMC_LIGHT_FUNCS, > > ASMC_MBA5_TEMPS, ASMC_MBA5_TEMPNAMES, ASMC_MBA5_TEMPDESCS > > }, > > - > > + { > > + "MacBookAir6,2", "Apple SMC MacBook Air 13-inch (Early 2013)", > > + ASMC_SMS_FUNCS_DISABLED, > > + ASMC_FAN_FUNCS2, > > + ASMC_LIGHT_FUNCS, > > + ASMC_MBA6_TEMPS, ASMC_MBA6_TEMPNAMES, ASMC_MBA6_TEMPDESCS > > + }, > > { > > "MacBookAir7,1", "Apple SMC MacBook Air 11-inch (Early 2015)", > > ASMC_SMS_FUNCS_DISABLED, > > @@ -435,7 +441,6 @@ static const struct asmc_model asmc_models[] =3D { > > ASMC_LIGHT_FUNCS, > > ASMC_MBA7_TEMPS, ASMC_MBA7_TEMPNAMES, ASMC_MBA7_TEMPDESCS > > }, > > - > > { > > "MacBookAir7,2", "Apple SMC MacBook Air 13-inch (Early 2015)", > > ASMC_SMS_FUNCS_DISABLED, > > diff --git a/sys/dev/asmc/asmcvar.h b/sys/dev/asmc/asmcvar.h > > index a594710f1cbe..9db544a1450d 100644 > > --- a/sys/dev/asmc/asmcvar.h > > +++ b/sys/dev/asmc/asmcvar.h > > @@ -773,6 +773,31 @@ struct asmc_softc { > > "Ta0P", "Heatpipe", "Mainboard Proximit= y > 1", "Mainboard Proximity 2", \ > > "Palm Rest", "Memory Proximity" } > > > > +/* > > + * TODO: validate the temp zones for MBA 6.x ! > > + */ > > +#define ASMC_MBA6_TEMPS { "TB0T", "TB1T", "TB2T", \ > > + "TC0E", "TC0F", "TC0P", \ > > + "TC1C", "TC2C", "TCGC", "TCSA", \ > > + "TCXC", "THSP", "TM0P", "TPCD", \ > > + "Ta0P", "Th1H", "Tm0P", \ > > + "Ts0P", "Ts0S", NULL } > > + > > +#define ASMC_MBA6_TEMPNAMES { "enclosure1", "enclosure2", > "enclosure3", \ > > + "cputemp1", "cputemp2", "cpuproximity",= \ > > + "cpucore1", "cpucore2", "cpupeci", > "pecisa", \ > > + "TCXC", "THSP", "memorybank", "pchdie",= \ > > + "Ta0P", "heatpipe", > "mainboardproximity1", \ > > + "palmrest", "memoryproximity" } > > + > > +#define ASMC_MBA6_TEMPDESCS { "Enclosure Bottom 1", "Enclosur= e > Bottom 2", "Enclosure Bottom 3", \ > > + "CPU Temp 1", "CPU Temp 2", "CPU > Proximity", \ > > + "CPU Core 1", "CPU Core 2", "CPU Peci > Core", "PECI SA", \ > > + "TCXC", "THSP", "Memory Bank A", "PCH > Die", \ > > + "Ta0P", "Heatpipe", "Mainboard Proximit= y > 1", \ > > + "Palm Rest", "Memory Proximity" } > > + > > + > > #define ASMC_MBA7_TEMPS { "TB0T", "TB1T", "TB2T", \ > > "TC0E", "TC0F", "TC0P", \ > > "TC1C", "TC2C", \ > > --000000000000620ac005f305c38e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
yeah i meant markj, but i was sick and tired and somehow m= y brain crossed streams.

sorry!


-a


On Fri, 20 Jan 2023 at 21:55, Jessic= a Clarke <jrtc27@freebsd.org&g= t; wrote:
On 21 = Jan 2023, at 04:43, Adrian Chadd <adrian@FreeBSD.org> wrote:
>
> The branch main has been updated by adrian:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Dffc58e2ca36546d866bb6bd36a3aa8f762a01663<= /a>
>
> commit ffc58e2ca36546d866bb6bd36a3aa8f762a01663
> Author:=C2=A0 =C2=A0 =C2=A0Adrian Chadd <adrian@FreeBSD.org>
> AuthorDate: 2023-01-21 04:34:31 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Adrian Chadd <adrian@FreeBSD.org>
> CommitDate: 2023-01-21 04:34:31 +0000
>
>=C2=A0 =C2=A0 asmc: Add MacbookAir6,2
>
>=C2=A0 =C2=A0 Add in the zones for my MacbookAir6,2, a 2013 Macbook Air= .
>
>=C2=A0 =C2=A0 Tested - said Macbook Air 2013.=C2=A0 Thermal Zones and k= eyboard backlight
>=C2=A0 =C2=A0 control works fine.
>
>=C2=A0 =C2=A0 Differential Revision: https://reviews.freebsd.o= rg/D38073
>=C2=A0 =C2=A0 Approved by: jrtc27

Uh this is the first I=E2=80=99m hearing of this patch?

Jess

> ---
> sys/dev/asmc/asmc.c=C2=A0 =C2=A0 |=C2=A0 9 +++++++--
> sys/dev/asmc/asmcvar.h | 25 +++++++++++++++++++++++++
> 2 files changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c
> index bec0054e2dd7..337f641e4513 100644
> --- a/sys/dev/asmc/asmc.c
> +++ b/sys/dev/asmc/asmc.c
> @@ -427,7 +427,13 @@ static const struct asmc_model asmc_models[] =3D = {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_LIGHT_FUNCS,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_MBA5_TEMPS, ASMC_MBA5_TEMPNAMES,= ASMC_MBA5_TEMPDESCS
>=C2=A0 =C2=A0 =C2=A0 =C2=A0},
> -
> +=C2=A0 =C2=A0 =C2=A0{
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"MacBookAir6,2", "Apple SMC= MacBook Air 13-inch (Early 2013)",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_SMS_FUNCS_DISABLED,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_FAN_FUNCS2,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_LIGHT_FUNCS,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_MBA6_TEMPS, ASMC_MBA6_TEMPNAMES, ASMC= _MBA6_TEMPDESCS
> +=C2=A0 =C2=A0 =C2=A0},
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"MacBookAir7,1", "Appl= e SMC MacBook Air 11-inch (Early 2015)",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_SMS_FUNCS_DISABLED,
> @@ -435,7 +441,6 @@ static const struct asmc_model asmc_models[] =3D {=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_LIGHT_FUNCS,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_MBA7_TEMPS, ASMC_MBA7_TEMPNAMES,= ASMC_MBA7_TEMPDESCS
>=C2=A0 =C2=A0 =C2=A0 =C2=A0},
> -
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"MacBookAir7,2", "Appl= e SMC MacBook Air 13-inch (Early 2015)",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_SMS_FUNCS_DISABLED,
> diff --git a/sys/dev/asmc/asmcvar.h b/sys/dev/asmc/asmcvar.h
> index a594710f1cbe..9db544a1450d 100644
> --- a/sys/dev/asmc/asmcvar.h
> +++ b/sys/dev/asmc/asmcvar.h
> @@ -773,6 +773,31 @@ struct asmc_softc {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Ta0P", "Hea= tpipe", "Mainboard Proximity 1", "Mainboard Proximity 2= ", \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Palm Rest", &quo= t;Memory Proximity" }
>
> +/*
> + * TODO: validate the temp zones for MBA 6.x !
> + */
> +#define=C2=A0 =C2=A0 =C2=A0 ASMC_MBA6_TEMPS=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0{ "TB0T", "TB1T", "TB2T", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"TC0E", "TC0F"= ;, "TC0P", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"TC1C", "TC2C"= ;, "TCGC", "TCSA", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"TCXC", "THSP"= ;, "TM0P", "TPCD", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Ta0P", "Th1H"= ;, "Tm0P", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Ts0P", "Ts0S"= ;, NULL }
> +
> +#define=C2=A0 =C2=A0 =C2=A0 ASMC_MBA6_TEMPNAMES=C2=A0 =C2=A0 =C2=A0{ = "enclosure1", "enclosure2", "enclosure3", \ > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"cputemp1", "cpute= mp2", "cpuproximity", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"cpucore1", "cpuco= re2", "cpupeci", "pecisa", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"TCXC", "THSP"= ;, "memorybank", "pchdie", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Ta0P", "heatpipe&= quot;, "mainboardproximity1", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"palmrest", "memor= yproximity" }
> +
> +#define=C2=A0 =C2=A0 =C2=A0 ASMC_MBA6_TEMPDESCS=C2=A0 =C2=A0 =C2=A0{ = "Enclosure Bottom 1", "Enclosure Bottom 2", "Enclo= sure Bottom 3", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"CPU Temp 1", "CPU= Temp 2", "CPU Proximity", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"CPU Core 1", "CPU= Core 2", "CPU Peci Core", "PECI SA", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"TCXC", "THSP"= ;, "Memory Bank A", "PCH Die", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Ta0P", "Heatpipe&= quot;, "Mainboard Proximity 1", \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Palm Rest", "Memo= ry Proximity" }
> +
> +
> #define=C2=A0 =C2=A0 =C2=A0 =C2=A0ASMC_MBA7_TEMPS=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0{ "TB0T", "TB1T", "TB2T", \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"TC0E", "TC0= F", "TC0P", \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"TC1C", "TC2= C", \

--000000000000620ac005f305c38e--