From owner-cvs-all Wed Feb 19 18: 8:51 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D830737B401; Wed, 19 Feb 2003 18:08:49 -0800 (PST) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by mx1.FreeBSD.org (Postfix) with ESMTP id 057E743F75; Wed, 19 Feb 2003 18:08:49 -0800 (PST) (envelope-from winter@jurai.net) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by sasami.jurai.net (8.12.6/8.12.5) with ESMTP id h1K28bvA007132; Wed, 19 Feb 2003 21:08:46 -0500 (EST) (envelope-from winter@jurai.net) Date: Wed, 19 Feb 2003 21:08:37 -0500 (EST) From: "Matthew N. Dodd" To: Sam Leffler Cc: Maxime Henrion , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c In-Reply-To: <0b4101c2d864$49cbafd0$52557f42@errno.com> Message-ID: <20030219210447.V66355@sasami.jurai.net> References: <200302191833.h1JIXT2d013173@repoman.freebsd.org> <0b4101c2d864$49cbafd0$52557f42@errno.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 19 Feb 2003, Sam Leffler wrote: > When I did the struct ifnet fixups I almost changed if_init from void to > int to return an error code. Maybe it's not too late to do this before > the REELNG_5 branch? If if_init() fails then the interface does not have the IFF_RUNNING flag set. If things like the ioctl path need to return a status they can use tsleep() to wait for the adapter to actually come up. This can deal with the adapter going out to lunch or any other failure one might encounter. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message