From owner-freebsd-current@FreeBSD.ORG  Tue Sep 13 13:59:42 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 443C4106564A;
	Tue, 13 Sep 2011 13:59:42 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 0BCFE8FC0C;
	Tue, 13 Sep 2011 13:59:40 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA03034;
	Tue, 13 Sep 2011 16:59:39 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <4E6F61CA.6020003@FreeBSD.org>
Date: Tue, 13 Sep 2011 16:59:38 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:5.0) Gecko/20110705 Thunderbird/5.0
MIME-Version: 1.0
To: freebsd-current@FreeBSD.org, freebsd-fs@FreeBSD.org,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <20110901223646.14b8aae8@o2.pl> <4E60DBBD.1040703@FreeBSD.org>
	<4E679D3D.1000007@FreeBSD.org>
In-Reply-To: <4E679D3D.1000007@FreeBSD.org>
X-Enigmail-Version: 1.2pre
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: ZFS: i/o error - all block copies unavailable after upgrading
 to r225312
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Sep 2011 13:59:42 -0000

on 07/09/2011 19:35 Andriy Gapon said the following:
> on 02/09/2011 16:35 Andriy Gapon said the following:
>> Then:
>> - obtain this patch http://people.freebsd.org/~avg/zfstest.head.diff
>> - cd sys/boot/zfs
>> - apply the patch to zfstest.c
>> - cc -I. -I../../cddl/boot/zfs zfstest.c -o zfstest
>> - run the resulting binary as root and provide your pool device(s) as
>> parameter(s); e.g.:
>>   ./zfstest /dev/ada0p4
> 
> Thanks to a lot of excellent testing, debugging and analysis from Sebastian (which
> went behind the scenes) we now have this patch:
> http://people.freebsd.org/~avg/zfs-boot-gang.diff

I've updated the patch place.  The essence of the changes is the same, just done
in a slightly different fashion.  That should minimize the scope of the diff.
One extra change is that now the checksum is also verified for uberblock.

Pawel, can you please review it?

> The patch introduces the following changes:
> - checksum is now verified for gang header blocks
> - checksum is now verified for reconstituted data of whole gang blocks
>   (previously it is verified only for individual gang member leaf blocks)
> - reconstituted data of a whole gang block is now decompressed if the gang block
> is compressed
> 
> The last change is _the_ change.
> 
> If you use compression for a filesystem where your kernel resides and you get a
> problem with booting, then please test this patch and report back.
> 
> Many thanks to Sebastian!
> Additional heap of thanks to Doug Rabson who came up with the idea and
> implementation of zfstest.c!  This tool is of the immense help when debugging an
> issue like this one.
> 


-- 
Andriy Gapon