From owner-cvs-all@FreeBSD.ORG Thu Apr 17 13:37:33 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7509E37B40D for ; Thu, 17 Apr 2003 13:37:33 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 4E44F43FBD for ; Thu, 17 Apr 2003 13:37:32 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 48050 invoked by uid 1000); 17 Apr 2003 20:37:33 -0000 Date: Thu, 17 Apr 2003 13:37:33 -0700 (PDT) From: Nate Lawson To: Ian Dowse In-Reply-To: <20030417083659.5643E37B498@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2003 20:37:33 -0000 On Thu, 17 Apr 2003, Ian Dowse wrote: > Modified files: > sys/pci if_dc.c > Log: > Revert part of revision 1.97 by calling dc_stop() unconditionally > in dc_detach() instead of only calling it if the hardware is preset. > This is a workaround for page faults in softclock() after a `dc' > device was detached, caused by not disabling a timer before freeing > its memory. The bus_child_present() checks should probably be > re-added later, but only to avoid the hardware accesses and not the > other resource cleanups in dc_stop(). > > Approved by: njl Thank you for finding this. -Nate