From owner-cvs-all Thu Jul 20 9:56:44 2000 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.freebsd.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id C293237BFB6; Thu, 20 Jul 2000 09:56:22 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (hak.nat.Awfulhak.org [172.31.0.12]) by storm.FreeBSD.org.uk (8.9.3/8.9.3) with ESMTP id RAA81288; Thu, 20 Jul 2000 17:56:19 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id RAA03765; Thu, 20 Jul 2000 17:56:16 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200007201656.RAA03765@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: Sheldon Hearn Cc: Brian Somers , Jordan Hubbard , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Brian Somers , shin@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/lib/libc/net rcmd.3 rcmd.c In-Reply-To: Message from Sheldon Hearn of "Thu, 20 Jul 2000 18:44:33 +0200." <5777.964111473@axl.ops.uunet.co.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 20 Jul 2000 17:56:16 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Thu, 20 Jul 2000 17:31:16 +0100, Brian Somers wrote: > > > The don't set *ahost to NULL, it remains pointing to the free()d > > memory :-( > > Can you set it to NULL immediately following the free()? I can't think > of any reasons why this would be bad. No, not in the old code. The new version doesn't do a free(). The bug was that rcmd() accidently free()d what it was returning, before returning. > Ciao, > Sheldon. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message