From owner-freebsd-bugs@freebsd.org Mon Jul 23 16:20:46 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24D1F104F5FF for ; Mon, 23 Jul 2018 16:20:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B0D4C837F2 for ; Mon, 23 Jul 2018 16:20:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 6D900104F5FE; Mon, 23 Jul 2018 16:20:45 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3114F104F5FD for ; Mon, 23 Jul 2018 16:20:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C3A72837EF for ; Mon, 23 Jul 2018 16:20:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 18E5FBF4D for ; Mon, 23 Jul 2018 16:20:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6NGKhk7016007 for ; Mon, 23 Jul 2018 16:20:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6NGKh8d016006 for bugs@FreeBSD.org; Mon, 23 Jul 2018 16:20:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 229983] Incorrect logical operator while verifying the feasibility of setting auditpipe queue limit Date: Mon, 23 Jul 2018 16:20:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: aniketp@iitk.ac.in X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 16:20:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229983 Bug ID: 229983 Summary: Incorrect logical operator while verifying the feasibility of setting auditpipe queue limit Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: aniketp@iitk.ac.in The logical operator which verifies that the desired limit of auditpipe que= ue length to be set is between QLIMIT_MIN and QLIMIT_MAX is wrong. case AUDITPIPE_SET_QLIMIT: /* Lockless integer write. */ if (*(u_int *)data >=3D AUDIT_PIPE_QLIMIT_MIN || *(u_int *)data <=3D AUDIT_PIPE_QLIMIT_MAX) { should be case AUDITPIPE_SET_QLIMIT: /* Lockless integer write. */ if (*(u_int *)data >=3D AUDIT_PIPE_QLIMIT_MIN && *(u_int *)data <=3D AUDIT_PIPE_QLIMIT_MAX) { Steps to reproduce the bug: (On 12-CURRENT) #include #include #include #include #include void main() { int fd =3D open("/dev/auditpipe", O_RDWR); if (fd < 0) perror("auditpipe"); int qlimit_min;=20 ioctl(fd, AUDITPIPE_GET_QLIMIT_MIN, &qlimit_min); qlimit_min -=3D 5; \* Not allowed since it is less than QLIMIT_= MIN *\ ioctl(fd, AUDITPIPE_SET_QLIMIT, &qlimit_min); perror("set qlimit"); close(fd); } Output: "set qlimit: No error: 0" --=20 You are receiving this mail because: You are the assignee for the bug.=