Date: Wed, 5 Sep 2001 15:38:11 +0200 From: Bernd Walter <ticso@mail.cicely.de> To: freebsd-alpha@freebsd.org Subject: What is wrong with this patch? Message-ID: <20010905153811.F16349@cicely20.cicely.de>
next in thread | raw e-mail | index | archive | help
--HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The attached patch makes my alpha HALT directly after starting the kernel. From my point of view the pv_flags stuff is completely bit rot. But it makes a difference if I remove it. -- B.Walter COSMO-Project http://www.cosmo-project.de ticso@cicely.de Usergroup info@cosmo-project.de --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="alpha.pv_flags" Index: sys/alpha/alpha/pmap.c =================================================================== RCS file: /vol/freebsd-cvs/src/sys/alpha/alpha/pmap.c,v retrieving revision 1.64 diff -u -r1.64 pmap.c --- sys/alpha/alpha/pmap.c 2001/08/31 06:19:08 1.64 +++ sys/alpha/alpha/pmap.c 2001/09/05 07:41:31 @@ -607,7 +607,6 @@ m = &vm_page_array[i]; TAILQ_INIT(&m->md.pv_list); m->md.pv_list_count = 0; - m->md.pv_flags = 0; } /* @@ -2822,19 +2821,6 @@ } /* - * pmap_page_is_free: - * - * Called when a page is freed to allow pmap to clean up - * any extra state associated with the page. In this case - * clear modified/referenced bits. - */ -void -pmap_page_is_free(vm_page_t m) -{ - m->md.pv_flags = 0; -} - -/* * pmap_clear_reference: * * Clear the reference bit on the specified physical page. @@ -3194,8 +3180,8 @@ pv; pv = TAILQ_NEXT(pv, pv_list)) { #ifdef used_to_be - printf(" -> pmap %x, va %x, flags %x", - pv->pv_pmap, pv->pv_va, pv->pv_flags); + printf(" -> pmap %x, va %x", + pv->pv_pmap, pv->pv_va); #endif printf(" -> pmap %x, va %x", pv->pv_pmap, pv->pv_va); Index: sys/alpha/include/pmap.h =================================================================== RCS file: /vol/freebsd-cvs/src/sys/alpha/include/pmap.h,v retrieving revision 1.12 diff -u -r1.12 pmap.h --- sys/alpha/include/pmap.h 2001/07/24 07:13:05 1.12 +++ sys/alpha/include/pmap.h 2001/09/05 07:38:39 @@ -161,7 +161,6 @@ struct md_page { int pv_list_count; - int pv_flags; TAILQ_HEAD(,pv_entry) pv_list; }; Index: sys/vm/pmap.h =================================================================== RCS file: /vol/freebsd-cvs/src/sys/vm/pmap.h,v retrieving revision 1.40 diff -u -r1.40 pmap.h --- sys/vm/pmap.h 2001/03/07 05:29:21 1.40 +++ sys/vm/pmap.h 2001/09/05 07:39:55 @@ -90,9 +90,6 @@ struct proc; -#ifdef __alpha__ -void pmap_page_is_free __P((vm_page_t m)); -#endif void pmap_change_wiring __P((pmap_t, vm_offset_t, boolean_t)); void pmap_clear_modify __P((vm_page_t m)); void pmap_clear_reference __P((vm_page_t m)); Index: sys/vm/vm_page.c =================================================================== RCS file: /vol/freebsd-cvs/src/sys/vm/vm_page.c,v retrieving revision 1.173 diff -u -r1.173 vm_page.c --- sys/vm/vm_page.c 2001/08/25 05:00:44 1.173 +++ sys/vm/vm_page.c 2001/09/05 07:40:31 @@ -1146,10 +1146,6 @@ if (m->flags & PG_UNMANAGED) { m->flags &= ~PG_UNMANAGED; - } else { -#ifdef __alpha__ - pmap_page_is_free(m); -#endif } m->queue = PQ_FREE + m->pc; --HlL+5n6rz5pIUxbD-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010905153811.F16349>