From owner-freebsd-current@FreeBSD.ORG Fri Oct 19 19:04:46 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 490B816A421 for ; Fri, 19 Oct 2007 19:04:46 +0000 (UTC) (envelope-from darrenr@freebsd.org) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 0118013C478 for ; Fri, 19 Oct 2007 19:04:45 +0000 (UTC) (envelope-from darrenr@freebsd.org) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 265E43358A; Fri, 19 Oct 2007 15:04:45 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Fri, 19 Oct 2007 15:04:45 -0400 X-Sasl-enc: IYD9xP4MilNKYJspFu1ppewk84bh6BEDgOeE2C5Tqjax 1192820684 Received: from [192.168.1.101] (r6i146.net.upc.cz [89.176.8.146]) by mail.messagingengine.com (Postfix) with ESMTP id 5387F2242; Fri, 19 Oct 2007 15:04:44 -0400 (EDT) Message-ID: <4718FFC0.5030101@freebsd.org> Date: Fri, 19 Oct 2007 12:04:32 -0700 From: Darren Reed User-Agent: Thunderbird 1.5.0.13 (Windows/20070809) MIME-Version: 1.0 To: Max Laier References: <359284519.20071018014832@masm.elcom.ru> <200710172357.18221.max@love2party.net> <6210619899.20071018020530@masm.elcom.ru> <200710180021.39250.max@love2party.net> In-Reply-To: <200710180021.39250.max@love2party.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, "Victor M. Blood" Subject: Re: ipfilter cannot be build within because warning's are present X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: darrenr@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 19:04:46 -0000 Max Laier wrote: > On Thursday 18 October 2007, Victor M. Blood wrote: > >> On 18.10.2007, Max Laier wrote: >> >>> On Wednesday 17 October 2007, Victor M. Blood wrote: >>> >>>> Hi, All. >>>> >>>> I try to use options in kernel instead of a module build of the >>>> ipfilter and got error then kernel builds. >>>> >>>> I'm edit files: fil.c, ip_auth.h, ip_auth.h, ip_log.c ip_compat.h >>>> and correct #ifdef statament :) no more warnings... >>>> >>> ipf is likely broken anyway. See thread: "7.0 CURRENT, need help >>> with panic: Trying sleep, but thread marked as sleeping prohibited" >>> on this ML a few days back. That this warning went unnoticed tells >>> you something, too. >>> >> New version, new problems, no more to say) few days back I have panic >> with ip filter, now it seems as worked, after upgrade. >> >> #ipf -V >> ipf: IP Filter: v4.1.27 (404) >> Kernel: IP Filter: v4.1.27 >> Running: yes >> Log Flags: 0 = none set >> Default: block all, Logging: available >> Active list: 0 >> Feature mask: 0xe >> > > Is this with a WITNESS/INVARIANTS enabled kernel? From a quick glance at > the code you should see warnings on the ioctl path as there are copy > operations to/from userland with the lock held. > > Moving to rw_locks is the right direction, but the config path is still > broken. > The real fault here is if the system needs to page in/out over NFS in order to fulfill the copyin/out. Does devfs prevent a kldunload from being executed while calls (ioctl/read/write) are outstanding? Darren