From owner-freebsd-current@FreeBSD.ORG Sat Nov 17 16:26:28 2007 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CEFE16A41B; Sat, 17 Nov 2007 16:26:28 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mx.egr.msu.edu (surfnturf.egr.msu.edu [35.9.37.164]) by mx1.freebsd.org (Postfix) with ESMTP id BC6EE13C465; Sat, 17 Nov 2007 16:26:27 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from localhost (localhost.egr.msu.edu [127.0.0.1]) by mx.egr.msu.edu (Postfix) with ESMTP id E98792EB8DD; Sat, 17 Nov 2007 11:26:20 -0500 (EST) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mx.egr.msu.edu ([127.0.0.1]) by localhost (surfnturf.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iIdaQ5ySjj8L; Sat, 17 Nov 2007 11:26:20 -0500 (EST) Received: from localhost (daemon.egr.msu.edu [35.9.44.65]) by mx.egr.msu.edu (Postfix) with ESMTP id BFAA22EB8DB; Sat, 17 Nov 2007 11:26:20 -0500 (EST) Received: by localhost (Postfix, from userid 21281) id BBF3C33C22; Sat, 17 Nov 2007 11:26:20 -0500 (EST) Date: Sat, 17 Nov 2007 11:26:20 -0500 From: Adam McDougall To: Robert Watson Message-ID: <20071117162620.GR46369@egr.msu.edu> References: <698405.85667.qm@web31809.mail.mud.yahoo.com> <20071116143239.U10677@fledge.watson.org> <20071116164549.GF37473@egr.msu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071116164549.GF37473@egr.msu.edu> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Timo Sirainen , freebsd-current@FreeBSD.org, Mohan Srinivasan , mohans@FreeBSD.org Subject: Re: link() not increasing link count on NFS server X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2007 16:26:28 -0000 On Fri, Nov 16, 2007 at 11:45:49AM -0500, Adam McDougall wrote: On Fri, Nov 16, 2007 at 02:37:56PM +0000, Robert Watson wrote: OK, I've attached an initial patch that does this -- we still need to keep the lookup code for NFSv2, where the file handle of the new node isn't returned with the reply, but I drop the EEXIST handling cases. Does this look reasonable to you? I'm not set up to easily test this scenario, however. Robert N M Watson I should be able to test this patch (or a later version) this weekend. Seems to work. I ran the original test case for several minutes without error for over 2000 iterations. I only tested it on -stable by applying the patch manually. If it is required I test it verbatim on 7, let me know and I will. Thanks.