Date: Fri, 7 Apr 2023 19:21:37 GMT From: Gleb Smirnoff <glebius@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: de4368dd84a0 - main - tcp: retire tfb_tcp_hpts_do_segment() Message-ID: <202304071921.337JLbxe007575@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=de4368dd84a0b3eec8069489e212b1c951f4bb4b commit de4368dd84a0b3eec8069489e212b1c951f4bb4b Author: Gleb Smirnoff <glebius@FreeBSD.org> AuthorDate: 2023-04-07 19:18:02 +0000 Commit: Gleb Smirnoff <glebius@FreeBSD.org> CommitDate: 2023-04-07 19:18:02 +0000 tcp: retire tfb_tcp_hpts_do_segment() Isn't in use anymore. Correct comments that mention it. Reviewed by: rrs Differential Revision: https://reviews.freebsd.org/D39433 --- sys/netinet/tcp_stacks/rack_bbr_common.c | 7 +++---- sys/netinet/tcp_var.h | 4 ---- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack_bbr_common.c b/sys/netinet/tcp_stacks/rack_bbr_common.c index d4a70c529386..1bc0823eef2a 100644 --- a/sys/netinet/tcp_stacks/rack_bbr_common.c +++ b/sys/netinet/tcp_stacks/rack_bbr_common.c @@ -334,13 +334,12 @@ ctf_process_inbound_raw(struct tcpcb *tp, struct socket *so, struct mbuf *m, int * We process each one by: * a) saving off the next * b) stripping off the ether-header - * c) formulating the arguments for - * the tfb_tcp_hpts_do_segment - * d) calling each mbuf to tfb_tcp_hpts_do_segment + * c) formulating the arguments for tfb_do_segment_nounlock() + * d) calling each mbuf to tfb_do_segment_nounlock() * after adjusting the time to match the arrival time. * Note that the LRO code assures no IP options are present. * - * The symantics for calling tfb_tcp_hpts_do_segment are the + * The symantics for calling tfb_do_segment_nounlock() are the * following: * 1) It returns 0 if all went well and you (the caller) need * to release the lock. diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h index 6018e84bfe64..cc3d7c294eea 100644 --- a/sys/netinet/tcp_var.h +++ b/sys/netinet/tcp_var.h @@ -602,10 +602,6 @@ struct tcp_function_block { struct socket *, struct tcpcb *, int, int, uint8_t, int, struct timeval *); - void (*tfb_tcp_hpts_do_segment)(struct mbuf *, struct tcphdr *, - struct socket *, struct tcpcb *, - int, int, uint8_t, - int, struct timeval *); int (*tfb_tcp_ctloutput)(struct inpcb *inp, struct sockopt *sopt); /* Optional memory allocation/free routine */ int (*tfb_tcp_fb_init)(struct tcpcb *, void **);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304071921.337JLbxe007575>