From owner-cvs-all Thu Jul 11 8: 6:29 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4C8137B400; Thu, 11 Jul 2002 08:06:24 -0700 (PDT) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55EC643E09; Thu, 11 Jul 2002 08:06:24 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.4) with ESMTP id g6BF6OLA080710; Thu, 11 Jul 2002 08:06:24 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.4/Submit) id g6BF6O61080709; Thu, 11 Jul 2002 08:06:24 -0700 (PDT) (envelope-from dillon) Date: Thu, 11 Jul 2002 08:06:24 -0700 (PDT) From: Matthew Dillon Message-Id: <200207111506.g6BF6O61080709@apollo.backplane.com> To: Sheldon Hearn Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_bio.c vfs_cluster.c vfs_subr.c src/sys/nfsclient nfs_bio.c src/sys/nfsserver nfs_serv.c src/sys/sys buf.h vnode.h References: <200207101702.g6AH2Xtl000528@freefall.freebsd.org> <20020711071201.GD25502@starjuice.net> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :> vnode->v_dirtyblkhd is now perfectly sorted, making :> fsync/sync/filesystem syncer operate more efficiently. : :This is very good for MTAs, yes? Do you have any informal stats that :suggest what kind of improvement this offers? : :Ciao, :Sheldon. No. The difference will not be noticeable because most of the common cases were already covered by the code that the splay tree replaced, and splay tree will have the same or slightly more overhead then the hash table that was there before. And the mail messages handled by MTAs are typically too small for it to matter anyway. The advantages will come in follow-up work... the ability to do partial fsyncs, optimal ranged syncs (commit rpc handling on the server side), and making it easier to pushdown locks into the VFS system (no more global hash table == easier to pushdown locks). As outlined in the commit message. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message