From owner-freebsd-hackers@freebsd.org Thu Dec 7 04:17:43 2017 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 620B8E9BCD7 for ; Thu, 7 Dec 2017 04:17:43 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-163.reflexion.net [208.70.210.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 10C5474C9C for ; Thu, 7 Dec 2017 04:17:42 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 18867 invoked from network); 7 Dec 2017 04:17:35 -0000 Received: from unknown (HELO rtc-sm-01.app.dca.reflexion.local) (10.81.150.1) by 0 (rfx-qmail) with SMTP; 7 Dec 2017 04:17:35 -0000 Received: by rtc-sm-01.app.dca.reflexion.local (Reflexion email security v8.40.3) with SMTP; Wed, 06 Dec 2017 23:17:35 -0500 (EST) Received: (qmail 22177 invoked from network); 7 Dec 2017 04:17:35 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 7 Dec 2017 04:17:35 -0000 Received: from [192.168.1.25] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id E7D79EC9524; Wed, 6 Dec 2017 20:17:34 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: SPDX tags in file? From: Mark Millard In-Reply-To: <20171207035704.GA54501@troutmask.apl.washington.edu> Date: Wed, 6 Dec 2017 20:17:34 -0800 Cc: Pedro Giffuni , FreeBSD Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <09278744-3D5C-4B8A-9134-934F9CCA1FF0@dsl-only.net> References: <4247a923-a297-1626-a576-a13651da90ab@FreeBSD.org> <20171207035704.GA54501@troutmask.apl.washington.edu> To: sgk@troutmask.apl.washington.edu X-Mailer: Apple Mail (2.3273) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 04:17:43 -0000 On 2017-Dec-6, at 7:57 PM, Steve Kargl wrote: > On Wed, Dec 06, 2017 at 09:17:06PM -0500, Pedro Giffuni wrote: >>=20 >>> It seems that the application of SPDX license tags >>> has been automated and done without reviewing whether >>> the tag is correct. For example, the BSD-4-Clause >>> tag has been placed in the files in lib/msun/bsdsrc. >>> Given the UCB letter concerning removal of clauses >>> 3 and 4, these files should probably have had the >>> Copyright updated and a different SPDX clause applied. >>>=20 >>> --=20 >>> Steve >>=20 >> The initial sweep was done manually, but as you might have noticed, = it=20 >> covered a lot of files and mistakes are certainly possible. >>=20 >> The idea at this time is/was not to replace licenses: I am not a = lawyer=20 >> but I think we may have to look at who has touched a file before = doing=20 >> any license change. That may be a complex process. >>=20 >> This said. checking for bsd-4-clause is a pretty good opportunity to=20= >> review and modernize code. If the code comes from another BSD (and=20 >> particularly NetBSD as I noticed during the sweep), it is likely=20 >> upstream has updated the license as well and there may be interesting=20= >> changes involved. >>=20 >=20 > Not all revisions apply to all four files >=20 > r1573 rgrimes BSD 4.4 Lite > r8870 rgrimes Trailing whitespace > r84210 dillon Add __FBSDID > r92887 obrien Fix SCM ID's > r92917 obrien Remove __P() usage. > r93211 bde Resurrect Lite1 > r97407 keramida Assume __STDC__ > r108533 schweikh Typos and whitespace > r129312 stefanf Remove some kludges (use C99 hexadecimal constant) > r138924 das Cosmetic changes only > r138925 das GC unused declaration > r150318 bde Fixed aliasing bugs in TRUNC() > r152566 bde Removed an unused declaration and style bugs > r169209 bde Document current (slightly broken) handling of = special values > r169212 bde Fix tgamma() on some special args > r176449 das Eliminate some warnings > r226414 das Fix some non-standard variable declarations. > r325966 pfg spdx >=20 > If you don't count UCB as upstream (aka r1573), then FreeBSD is > upstream. Looking at NetBSD the commit message for b_tgamma.c > is "Add tgamma{,f} from FreeBSD via rudolf, netbsd at eq dot cz". > OpenBSD is a little more complicated, but its initial version=20 > appeared in 2008 while FreeBSD's appeard in 1994. >=20 > IMHO (non-lawyer) opinion, the only thing that might rise to the > level of Copyright-able material would be r169212. Bruce did not > add his name as he has done elsewhere. >=20 > BTW, OpenBSD uses a 3-clause BSD license. That prompted an old memory about newer code for OpenBSD so I took a look. . . https://www.openbsd.org/policy.html says: ISC The ISC copyright is functionally equivalent to a two-term BSD copyright with language removed that is made unnecessary by the Berne convention. This is the preferred license for new code incorporated into OpenBSD. A sample license is available in the file /usr/share/misc/license.template. =3D=3D=3D Mark Millard markmi at dsl-only.net