From owner-freebsd-doc Mon May 27 13:50:20 2002 Delivered-To: freebsd-doc@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 0173037B406 for ; Mon, 27 May 2002 13:50:02 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g4RKo1222885; Mon, 27 May 2002 13:50:01 -0700 (PDT) (envelope-from gnats) Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.130.111.12]) by hub.freebsd.org (Postfix) with ESMTP id C960D37B400 for ; Mon, 27 May 2002 13:47:21 -0700 (PDT) Received: from pulcherrima.dbai.tuwien.ac.at (pulcherrima [128.130.111.23]) by vexpert.dbai.tuwien.ac.at (8.11.6/8.11.6) with ESMTP id g4RKlJK24148; Mon, 27 May 2002 22:47:19 +0200 (MET DST) Received: (from pfeifer@localhost) by pulcherrima.dbai.tuwien.ac.at (8.11.6/8.11.6) id g4RKlE963257; Mon, 27 May 2002 22:47:14 +0200 (CEST) (envelope-from pfeifer) Message-Id: <200205272047.g4RKlE963257@pulcherrima.dbai.tuwien.ac.at> Date: Mon, 27 May 2002 22:47:14 +0200 (CEST) From: Gerald Pfeifer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: docs/38631: Update notes on CVS commit messages in Committers' Guide Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 38631 >Category: docs >Synopsis: Update notes on CVS commit messages in Committers' Guide >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon May 27 13:50:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: FreeBSD 4.5-RELEASE i386 >Organization: >Environment: >Description: This updates the notes on CVS commit messages in the Committer's Guide by explicitly adding (what is apparently) common wisdom concerning references to other committers. >How-To-Repeat: >Fix: Patch below; especially the end of the last chunk of this patch should be closely checked for markup issues. Index: article.sgml =================================================================== RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v retrieving revision 1.125 diff -u -3 -p -r1.125 article.sgml --- article.sgml 26 May 2002 23:35:19 -0000 1.125 +++ article.sgml 27 May 2002 20:30:13 -0000 @@ -2422,28 +2422,34 @@ cvs add: use 'cvs commit' to add this fi Submitted by: The name and e-mail address of the person that - submitted the fix. + submitted the fix; for committers, just the username on + the FreeBSD cluster. Reviewed by: The name and e-mail address of the person or people - that reviewed the change. If a patch was submitted to a - mailing list for review, and the review was favorable, - then just include the list name. + that reviewed the change; for committers, just the + username on the FreeBSD cluster. If a patch was + submitted to a mailing list for review, and the review + was favorable, then just include the list name. Approved by: The name and e-mail address of the person or people - that approved the change. It is customary to get prior - approval for a commit if it is to an area of the tree to - which you do not usually commit. In addition, during the - run up to a new release all commits - must be approved by the release - engineer. If these are your first commits then you should - have passed them past your mentor first for approval, and - you should list your mentor. + that approved the change; for committers, just the + username on the FreeBSD cluster. It is customary to get + prior approval for a commit if it is to an area of the + tree to which you do not usually commit. In addition, + during the run up to a new release all commits + must be approved by the release + engineering team. If these are your first commits then + you should have passed them past your mentor first, and + you should list your mentor, as in + ``username-of-mentor + (mentor)''. + >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message