From owner-svn-ports-all@freebsd.org Thu Jul 14 15:09:34 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A110B9757F; Thu, 14 Jul 2016 15:09:34 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C0DA12D3; Thu, 14 Jul 2016 15:09:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f48.google.com with SMTP id f6so49497198ith.1; Thu, 14 Jul 2016 08:09:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=J3A1UGZID032uaZA5eFOgkma/W5pvULSW3pKH3cVyWw=; b=mRIpntPWMCG/IREmjlFd/j2QreUWueKQVAxTQbZSFCoNqwqZrdItN/wf8ZrGqKEdY7 FQodfOyHS7a2VBbL3J7L836GZ6IaLygRhkfe1XHrd5qn7I+3M93JBbJK51adipoSiPEv bhMTOyZ2fwNxVyyPyWfeOv/q/L4EBaBeB6iPyE31QmAFd5bj1RblftqxozgD10i8JqiZ 1eAToCBiJRpKOWJaj3SRERD+jUI2eU/3dwcfgptUyoFgFv+qnl5fkEmML3jz5/z53pg8 28kjKqqeUzvJb4QSeK/DuRGl8+JJ7inEJyCbams44OAltx1w81n7Lwaf1eerq+/FiHEQ rA6Q== X-Gm-Message-State: ALyK8tIFTn0Gr1tZAogPEDq+OZh2aFR9KYU7jj+W8MKkgKzM610/GqHuwRoyeLt6qQNl4w== X-Received: by 10.36.82.8 with SMTP id d8mr15872727itb.61.1468508967157; Thu, 14 Jul 2016 08:09:27 -0700 (PDT) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com. [209.85.214.53]) by smtp.gmail.com with ESMTPSA id v21sm1957732ita.0.2016.07.14.08.09.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jul 2016 08:09:27 -0700 (PDT) Received: by mail-it0-f53.google.com with SMTP id u186so50199673ita.0; Thu, 14 Jul 2016 08:09:26 -0700 (PDT) X-Received: by 10.36.29.5 with SMTP id 5mr14834222itj.97.1468508966680; Thu, 14 Jul 2016 08:09:26 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.206.2 with HTTP; Thu, 14 Jul 2016 08:09:26 -0700 (PDT) In-Reply-To: <20160714084653.quyjmu7g3e4f7d5b@ivaldir.etoilebsd.net> References: <201607140142.u6E1g9Sp056312@repo.freebsd.org> <20160714084653.quyjmu7g3e4f7d5b@ivaldir.etoilebsd.net> From: Conrad Meyer Date: Thu, 14 Jul 2016 08:09:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r418510 - head/devel/elfutils To: Baptiste Daroussin Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 15:09:34 -0000 On Thu, Jul 14, 2016 at 1:46 AM, Baptiste Daroussin wrote: > Which is exactly why non ports committers are not supposed to commit in the ports > tree without a ports committer review/approval. Sorry. I'm doing my best with the porter's handbook, just like anyone else. > At least at quick glance there is this: > - post-patch expects gnulib to already be installed but gnulib is a build > dependency and not a patch dependency so not installed at the momemt you > needed it Why have a PATCH_DEPENDS distinct from BUILD_DEPENDS? > - automake is not supposed to be run like this The port doesn't need a full autoreconf, just automake. It is intended to work in isolation to configure.ac/configure.in. The porter's handbook did not seem to provide any better direction here. > https://people.freebsd.org/~bapt/elfutils.diff > > Should fix those 2 issues Please go ahead and commit. Thanks, Conrad