From owner-cvs-all  Fri Feb 22 14:36:28 2002
Delivered-To: cvs-all@freebsd.org
Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122])
	by hub.freebsd.org (Postfix) with ESMTP
	id 79AA837B400; Fri, 22 Feb 2002 14:36:22 -0800 (PST)
Received: (from mike@localhost)
	by espresso.q9media.com (8.11.6/8.11.6) id g1MMVNq19713;
	Fri, 22 Feb 2002 17:31:23 -0500 (EST)
	(envelope-from mike)
Date: Fri, 22 Feb 2002 17:31:23 -0500
From: Mike Barcroft <mike@FreeBSD.org>
To: Andrew Gallatin <gallatin@cs.duke.edu>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/games/fortune/fortune fortune.c src/games/fortune/strfile strfile.c src/games/fortune/unstr unstr.c src/include/arpa inet.h src/include/rpc xdr.h src/lib/libc/alpha/net byte_swap_2.S byte_swap_4.S htonl.S htons.S ntohl.S ntohs.S ...
Message-ID: <20020222173123.C11124@espresso.q9media.com>
References: <200202182035.g1IKZRX56719@freefall.freebsd.org> <20020222171748.A81125@grasshopper.cs.duke.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020222171748.A81125@grasshopper.cs.duke.edu>; from gallatin@cs.duke.edu on Fri, Feb 22, 2002 at 05:17:48PM -0500
Organization: The FreeBSD Project
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Andrew Gallatin <gallatin@cs.duke.edu> writes:
> When compiling a kernel on alpha, I now see:
> 
> "warning: implicit declaration of function `__ntohs'"
> 
> In all places which use ntohs(), similar for the other 3 byteswapping
> routines. Don't you think these should at least be prototyped in
> sys/alpha/include/endian.h??
> 
> 
> Does this look OK?  It seems to fix the compile warnings, but I don't
> know what your plans are..

Hmm, I think the prototypes belong in <sys/param.h>.  Thomas has a new
patch which fixes this, as a side effect.  Alpha should really have
inline versions of these functions like i386 and ia64.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message