From owner-dev-commits-src-all@freebsd.org Mon Jun 28 17:26:52 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 63A496594D6; Mon, 28 Jun 2021 17:26:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GDF0D2MbXz3lgK; Mon, 28 Jun 2021 17:26:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 35023B59E; Mon, 28 Jun 2021 17:26:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f54.google.com with SMTP id p7so6458217qvn.5; Mon, 28 Jun 2021 10:26:52 -0700 (PDT) X-Gm-Message-State: AOAM532HnVKm+k8iAv6F8dsM3odbZh5YPtG31LYNycJV4aAw/ewfT5YB dUzfNwW00DGqkzdKKj0Yy5u9eAoL0Rjpegm07lM= X-Google-Smtp-Source: ABdhPJyN0u0HNPYFKP48OGNi2LsP9Giq9W58ENAmd+BcApJYvNl+xE0OxhaNRC++qA8jz9+tLYOvIIMtqHb4b+7HIOA= X-Received: by 2002:ad4:4b22:: with SMTP id s2mr26711256qvw.22.1624901211885; Mon, 28 Jun 2021 10:26:51 -0700 (PDT) MIME-Version: 1.0 References: <202106281537.15SFbdiG002780@gitrepo.freebsd.org> In-Reply-To: <202106281537.15SFbdiG002780@gitrepo.freebsd.org> From: Kyle Evans Date: Mon, 28 Jun 2021 10:26:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 175841285e28 - main - Add deprecation notice for WITH_PROFILE option To: Ed Maste Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 17:26:52 -0000 On Mon, Jun 28, 2021 at 8:37 AM Ed Maste wrote: > > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=175841285e289edebb6603da39f02549521ce950 > > commit 175841285e289edebb6603da39f02549521ce950 > Author: Ed Maste > AuthorDate: 2021-06-27 17:21:26 +0000 > Commit: Ed Maste > CommitDate: 2021-06-28 15:36:59 +0000 > > Add deprecation notice for WITH_PROFILE option > > As discussed on freebsd-current [1] and freebsd-arch [2] and review > D30833, FreeBSD 14 will ship without the _p.a libraries built with -pg. > Both upstream and base system (in commit b762974cf4b9) Clang have been > modified to remove the special case for linking against these libraries. > > Clang's -pg support and mcount() remain, so building with -pg can still > be used on code that the user builds; we just do not provide prebuilt > libraries compiled with -pg. A similar change is still needed for GCC. > > [1] https://lists.freebsd.org/pipermail/freebsd-current/2020-January/075105.html > [2] https://lists.freebsd.org/archives/freebsd-arch/2021-June/000016.html > > MFC after: 1 week > Sponsored by: The FreeBSD Foundation > --- > tools/build/options/WITHOUT_PROFILE | 2 ++ > tools/build/options/WITH_PROFILE | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/tools/build/options/WITHOUT_PROFILE b/tools/build/options/WITHOUT_PROFILE > index 7fdb12c94cdd..5cc8dbb027c8 100644 > --- a/tools/build/options/WITHOUT_PROFILE > +++ b/tools/build/options/WITHOUT_PROFILE > @@ -1,3 +1,5 @@ > .\" $FreeBSD$ > Do not build profiled libraries for use with > .Xr gprof 8 . > +This option is enabled by default as of > +.Fx 14 . I know we could bikeshed this all day, but I think this verbiage is a little too casual; "enabled by default" makes it sound like it can be turned off, when it's really becoming non-optional. > diff --git a/tools/build/options/WITH_PROFILE b/tools/build/options/WITH_PROFILE > index 51814a1ea856..3f91c4394911 100644 > --- a/tools/build/options/WITH_PROFILE > +++ b/tools/build/options/WITH_PROFILE > @@ -1,3 +1,5 @@ > .\" $FreeBSD$ > Build profiled libraries for use with > .Xr gprof 8 . > +This option is deprecated and is not present in > +.Fx 14