From owner-freebsd-current@FreeBSD.ORG  Mon Apr 14 03:18:20 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B374337B401
	for <freebsd-current@freebsd.org>;
	Mon, 14 Apr 2003 03:18:20 -0700 (PDT)
Received: from colossus.systems.pipex.net (colossus.systems.pipex.net
	[62.241.160.73])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1062C43F3F
	for <freebsd-current@freebsd.org>;
	Mon, 14 Apr 2003 03:18:20 -0700 (PDT)
	(envelope-from gavin@ury.york.ac.uk)
Received: from endor.bu.nker.net (81-86-141-101.dsl.pipex.com [81.86.141.101])
	by colossus.systems.pipex.net (Postfix) with ESMTP
	id EDF7F160005CA; Mon, 14 Apr 2003 11:18:16 +0100 (BST)
Received: from endor.bu.nker.net (localhost [127.0.0.1])
	by endor.bu.nker.net (8.12.6/8.12.6) with ESMTP id h3EAIGpp047226;
	Mon, 14 Apr 2003 11:18:16 +0100 (BST)
	(envelope-from gavin@ury.york.ac.uk)
Received: from localhost (gavin@localhost)h3EAIFiE047223;
	Mon, 14 Apr 2003 11:18:15 +0100 (BST)
X-Authentication-Warning: endor.bu.nker.net: gavin owned process doing -bs
Date: Mon, 14 Apr 2003 11:18:14 +0100 (BST)
From: Gavin Atkinson <gavin@ury.york.ac.uk>
X-X-Sender: gavin@endor.bu.nker.net
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
In-Reply-To: <939.1050246582@critter.freebsd.dk>
Message-ID: <20030414105157.G47006-100000@endor.bu.nker.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: "Christoph P. Kukulies" <kuku@physik.rwth-aachen.de>
cc: freebsd-current@freebsd.org
Subject: Re: kernel: bad malloc : 4 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2003 10:18:21 -0000

On Sun, 13 Apr 2003, Poul-Henning Kamp wrote:
> In message <20030413140647.GA18474@gilberto.physik.rwth-aachen.de>, "Christoph
> P. Kukulies" writes:
> >Here is what I could type off the screen:
> >
> >Bad malloc flags: 4
>
> This means that malloc() was called with M_DONTWAIT which is a mbuf
> allocator flags.

It looks like this is done in a few places in other bits of code...

sys/netinet/ip_fw.c:        ipfw_dyn_v = malloc(curr_dyn_buckets * sizeof r,
sys/netinet/ip_fw.c-                   M_IPFW, M_DONTWAIT | M_ZERO);
sys/netinet/ip_fw.c-        if (ipfw_dyn_v == NULL)

sys/netinet6/frag6.c:           q6 = (struct ip6q *)malloc(sizeof(struct ip6q), M_FTABLE,
sys/netinet6/frag6.c-                   M_DONTWAIT);
sys/netinet6/frag6.c-           if (q6 == NULL)

sys/netinet6/frag6.c:   ip6af = (struct ip6asfrag *)malloc(sizeof(struct ip6asfrag), M_FTABLE,
sys/netinet6/frag6.c-       M_DONTWAIT);
sys/netinet6/frag6.c-   if (ip6af == NULL)

So, these are bad? It looks like they were fixed in January by imp, and
then backed out in February. I have no idea why it was backed out.

Gavin