From nobody Fri Jun 5 14:18:26 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gX3Sg6yb7z6fvWF; Fri, 05 Jun 2026 14:18:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gX3Sg6G6Bz3TrZ; Fri, 05 Jun 2026 14:18:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780669107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TgYuWqk0dyK/BwqWyiPHCSOEOop0azl+HimsS34L4jM=; b=AJ+Pqla4CU2BOl8kCJf7zU2X773kwmLetAJZ58SJbIaxlrAudKLl5A8bq8gFxdXoRBkB// rrEciQxh4tuu4KamNb36w7RS6lHZU9Du07y9Ej+k1rMcHPkpy04/w9ddE1OELFGf6gSaS6 c8mNSn2w1I9khUrLhHuuHOCV+0UNfFnJOewCbCtPHk/w8+nMeknT/18HNhZTssMYw8QTtj S4Qf7cWKmqiB6vUF722ByxGdWvPvkDO6FUBSgMqggcYHNzmFrdevvEQS9F1u2TQSYRgIyq cx+ettjKEEowCg6oOWzPGf4vha57ZOd3Ta9twzmRq3emKlkSEeL4oZd/MLbKcg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780669107; a=rsa-sha256; cv=none; b=hgFrSG0YwecZwJ17DpAC8o99f/iZ+8ss9QWdGJdi39xQOUdtxNe85J4lCCTKo8BEIImK/m fD8WiUd6VWTbaj43IpBy0mxQ+lJJJaTMF8rDtv25VonhsBdHTh5WT65Qi0f5iCcQ3+xmTk Bwsy80ajDMZWaGmEgJwTbo2naiY1bJnmHPblT1Uc9lOhkcPnloFUmu2A0+rKcuZzw3HS0Q Hc1S6YAh8cwNmX7RZYMlJ2pfbNHOHNbvxr+wYqR62RQQYPoQI2ZiJ6Akva+/yVHQ3M2ysK i2HLegSspkyFgGM+gdBZpzujoPN3StQ/GlwvrkFPlFktWFgNdg8ITXxLZTvoWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780669107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TgYuWqk0dyK/BwqWyiPHCSOEOop0azl+HimsS34L4jM=; b=mA1LqVpcNuV9bi+Vm9Wn0IRgJh13u8fVQpcDgi0TqS9+borAAv3wv9sFepBlOjjWj1o3gP FYfqp7Y/TYARbvCG2ZrJrAGjKdW3QDozBP2FpK6wLvpsjhqdOeILHMh8huSen7CojKFT7C ZhE6TPEGJ51rLQBYpUO5zcbaBKKv26tNmDWxNOyK231TcCjj2IaQZYyLr15etbsJQqXibq b9zADLo6cCB2Rnr6V1mRg3D5fIZFFM6XZhGJVqSAV/bB174o0iOGSy/t6RZGABRspgAjGq MU5jIoGfRlecsmO2ZMaeJ4q2gKkYaIyCZ2E9grxdyST4gma55nKNeT63Ni7FSQ== Received: from [IPV6:2601:5c0:4202:5670:d479:80fa:603d:546e] (unknown [IPv6:2601:5c0:4202:5670:d479:80fa:603d:546e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gX3Sg4KrYzPKj; Fri, 05 Jun 2026 14:18:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <711a1680-9b9f-4b2a-a97f-d1cc9523c5f6@FreeBSD.org> Date: Fri, 5 Jun 2026 10:18:26 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 7487932f4fbc - main - assert.h: style(9): Space after #define, between #endif and comment Content-Language: en-US To: Olivier Certner , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a2166aa.22490.59890f0d@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <6a2166aa.22490.59890f0d@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/4/26 07:51, Olivier Certner wrote: > The branch main has been updated by olce: > > URL: https://cgit.FreeBSD.org/src/commit/?id=7487932f4fbc5a71231d3b1fc93d160253f38c83 > > commit 7487932f4fbc5a71231d3b1fc93d160253f38c83 > Author: Olivier Certner > AuthorDate: 2026-06-02 10:01:05 +0000 > Commit: Olivier Certner > CommitDate: 2026-06-04 11:49:26 +0000 > > assert.h: style(9): Space after #define, between #endif and comment > > style(9) still allows TAB after #define but this is a historical > artifact and by far the minority of uses cases. Going forward, we would > like to promote the use of a single space, as it allows alignment to > survive line prefixing (such as in diffs). It is not "by far the minority" and is still widely used. Excluding contrib it is still about 1/3 of the cases in the tree. > style(9) also has prescribed a single space between '#else' or '#endif' > and a comment recalling the guard since 2002. > > So, commit 157c184689ea ("assert.h: Remove leading tabs for whitespace > consistency") was good, and in line with rules about whitespace changes > (since the file was heavily modified by surrounding commits). > > This commit is thus basically a revert of 439710cf003b ("assert.h: > Revert "Remove leading tabs for whitespace consistency"), which extended > replacing spaces with TABs in the code introduced in the meantime (after > commit 157c184689ea). > > Reviewed by: fuz, imp > Fixes: 439710cf003b ("assert.h: Revert "Remove leading tabs for whitespace consistency") > MAC after: 3 days > Differential Revision: https://reviews.freebsd.org/D57391 This was not worth yet another commit to this file absolutely destroying git blame. Please cool it a bit on going on holy wars over pushing for changes to historical style and then committing style-only changes. It adds needless churn to our tree, makes git blame harder (ignore-revs aside), and also adds pain to downstreams who maintain forks of FreeBSD. -- John Baldwin