From owner-cvs-src@FreeBSD.ORG Tue Aug 1 00:39:41 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0C0216A4E7 for ; Tue, 1 Aug 2006 00:39:41 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.174]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BD2043D55 for ; Tue, 1 Aug 2006 00:39:38 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by ug-out-1314.google.com with SMTP id m2so1111441uge for ; Mon, 31 Jul 2006 17:39:37 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=omnlnJoKTeZfkNwkbyJdQkG/wiw7ZbMxB/lBGJKuGHlQUXIaTe2dMLNDejSQFuzVz46cZLfPEV/vVYDd50fNHOpsauqNURViEPoFZ9gJXWAzH2DCTHi0yJy3Ql699TgWWxb1fwF3MZZDE+j91yfbO4l+huJFC2ZvgAF5lrlvYAU= Received: by 10.65.83.18 with SMTP id k18mr247578qbl; Mon, 31 Jul 2006 17:39:36 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 15sm6467189nzp.2006.07.31.17.39.33; Mon, 31 Jul 2006 17:39:36 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k710eHTR039896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Aug 2006 09:40:17 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k710eGHX039895; Tue, 1 Aug 2006 09:40:16 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 1 Aug 2006 09:40:16 +0900 From: Pyun YongHyeon To: Gleb Smirnoff Message-ID: <20060801004016.GB39581@cdnetworks.co.kr> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> <20060731131502.GS96644@FreeBSD.org> <20060731144841.Y71432@fledge.watson.org> <20060731194311.GV96644@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060731194311.GV96644@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2006 00:39:41 -0000 On Mon, Jul 31, 2006 at 11:43:11PM +0400, Gleb Smirnoff wrote: > On Mon, Jul 31, 2006 at 02:49:05PM +0100, Robert Watson wrote: > R> On Mon, 31 Jul 2006, Gleb Smirnoff wrote: > R> > R> >On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: > R> >P> yongari 2006-07-20 03:57:58 UTC > R> >P> > R> >P> FreeBSD src repository > R> >P> > R> >P> Modified files: > R> >P> sys/dev/em if_em.c > R> >P> Log: > R> >P> Honor IFF_DRV_OACTIVE in em_start_locked(). > R> > > R> >Isn't it better to shift this change to the em_start(), to avoid double > R> >check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the > R> >em_start()? > R> > R> Isn't em_start_locked() called from quite a few different places, including > R> the interrupt handler, etc, where the mutex is already held? > > It is, so the latter idea won't work. However, in all these places > we can know the status of IFF_DRV_OACTIVE before calling the start > routine. > You're right. Feel free to fix it. I have to solve re(4) issues on sparc64 at the moment... -- Regards, Pyun YongHyeon