From owner-freebsd-current  Mon Aug  5  1:31:14 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7B71F37B400; Mon,  5 Aug 2002 01:31:11 -0700 (PDT)
Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9A3BA43E42; Mon,  5 Aug 2002 01:31:10 -0700 (PDT)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.3) with ESMTP id g758VAE06449;
	Mon, 5 Aug 2002 04:31:10 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Mon, 5 Aug 2002 04:31:10 -0400 (EDT)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Mike Barcroft <mike@FreeBSD.org>
Cc: jeff@FreeBSD.org, <current@FreeBSD.org>
Subject: Re: i386 tinderbox failure
In-Reply-To: <20020805031658.A29240@espresso.q9media.com>
Message-ID: <20020805043003.L86323-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Mon, 5 Aug 2002, Mike Barcroft wrote:

> Dag-Erling Smorgrav <des@FreeBSD.org> writes:
> > cc1: warnings being treated as errors
> > /local0/scratch/des/src/sys/kern/vfs_cache.c: In function `vn_fullpath':
> > /local0/scratch/des/src/sys/kern/vfs_cache.c:824: warning: `vp' might be used uninitialized in this function
> > *** Error code 1
>
> Jeff,
> This assertion can't be right since vp will always be uninitialized.
> Does it need to be moved into the for loop a few lines below, or is
> checking vn sufficient?
>
> Best regards,
> Mike Barcroft
>

Yeah, it needs to be moved into the loop.  Really, I put the assertion
there so I would fix this later.  I already know that it will fail.  I
guess I didn't notice that I had turned of DEBUG_VFS_LOCKS in my kernel
config.  Thanks for pointing this out.

Jeff


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message