From owner-dev-commits-src-main@freebsd.org Fri Mar 5 20:40:53 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 38D30566CE1; Fri, 5 Mar 2021 20:40:53 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dsfl84mxsz3j3q; Fri, 5 Mar 2021 20:40:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id IHFgl8RKX2SWTIHFil4rL0; Fri, 05 Mar 2021 13:40:50 -0700 X-Authority-Analysis: v=2.4 cv=fdJod2cF c=1 sm=1 tr=0 ts=60429753 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dESyimp9J3IA:10 a=6I5d2MoRAAAA:8 a=pGLkceISAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=vEtR2WbTRQCnyGjxLlMA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 a=BPzZvq435JnGatEyYwdK:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id B6E0E230; Fri, 5 Mar 2021 12:40:47 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 125Kelsl004737; Fri, 5 Mar 2021 12:40:47 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202103052040.125Kelsl004737@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Stefan Esser cc: Kyle Evans , John Baldwin , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c. In-reply-to: <3e76fccd-efeb-1479-7418-7e69bed98915@freebsd.org> References: <202103051755.125HtZsc073704@gitrepo.freebsd.org> <3e76fccd-efeb-1479-7418-7e69bed98915@freebsd.org> Comments: In-reply-to Stefan Esser message dated "Fri, 05 Mar 2021 21:27:35 +0100." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 05 Mar 2021 12:40:47 -0800 X-CMAE-Envelope: MS4xfJI/llbE9bRkw0PzZlXdlU6gsNwrqLWgzg2a0h2fJH0NAAFmqMrO0FfhpOs55AMYOtlM2zGOhQxnuUytgN30k9bwOlHNz79QATiCN++ETLC+oO9PzNIE 1HXdcc8eawbZpbEcPWLNTCIBHneJNICoLPHR8YtLslOoUpNAWrbyrtK0qEHYfxShwRkPGWuGdW9cRnxFcZaDYxBDVCShZIXnLlpzJSj2x0uRUm4kHbAqQx2c XBrHq4EqtQp3EdId+Bx+qjrD69MQ+A3qMkAmBTE9ko9eCJs9z7kej/HP7gT0mH/9cF4ZNmb/mnSPM8vyHwwIPNzXtYckBpcwBTSYWbHpoQSAlTWvGtLgJ/1p qczVMQPAf5rNgQsbS7ISWmsyGSFTXQ== X-Rspamd-Queue-Id: 4Dsfl84mxsz3j3q X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 20:40:53 -0000 In message <3e76fccd-efeb-1479-7418-7e69bed98915@freebsd.org>, Stefan Esser wri tes: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --BzEcQZ2nusRpdURvGKXTcE63zI1f9CPzu > Content-Type: multipart/mixed; boundary="j85mRpT9Yj12HfXzWxaH0rMreDxXIgaOS"; > protected-headers="v1" > From: Stefan Esser > To: Kyle Evans , John Baldwin > Cc: src-committers , > dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org > Message-ID: <3e76fccd-efeb-1479-7418-7e69bed98915@freebsd.org> > Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic > Poly1305_* symbols from xform_poly1305.c. > References: <202103051755.125HtZsc073704@gitrepo.freebsd.org> > > In-Reply-To: com> > > --j85mRpT9Yj12HfXzWxaH0rMreDxXIgaOS > Content-Type: text/plain; charset=utf-8; format=flowed > Content-Language: de-DE > Content-Transfer-Encoding: quoted-printable > > Am 05.03.21 um 21:05 schrieb Kyle Evans: > > On Fri, Mar 5, 2021 at 11:55 AM John Baldwin wrote: > >> > >> The branch main has been updated by jhb: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbb6e84c988d3f54eff602ed= > 544ceaa9b9fe3e9ff > >> > >> commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff > >> Author: John Baldwin > >> AuthorDate: 2021-03-05 17:47:58 +0000 > >> Commit: John Baldwin > >> CommitDate: 2021-03-05 17:55:11 +0000 > >> > >> poly1305: Don't export generic Poly1305_* symbols from xform_poly= > 1305.c. > >> > >> There currently isn't a need to provide a public interface to a > >> software Poly1305 implementation beyond what is already available= > via > >> libsodium's APIs and these symbols conflict with symbols shared w= > ithin > >> the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c. > >> > >> Reported by: se, kp > >> Fixes: 78991a93eb9d > >> Sponsored by: Netflix > >> --- > >> sys/opencrypto/xform_poly1305.c | 43 ++++++++++++-------------------= > ---------- > >> sys/opencrypto/xform_poly1305.h | 16 --------------- > >> 2 files changed, 12 insertions(+), 47 deletions(-) > >=20 > > xform_poly1305.h also needs to stop being grouped in > > ^/include/Makefile (reported by jenkins via np) > > AFAICT, sys/opencrypto/xform_poly1305.h needs to be restored ... > > It is needed during buildworld (and present in stable/13). Indeed. `xform_poly1305.h' was not built (being made, type OP_DEPS_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONE_ALLSRC|DONECYCLE)! `_INCSINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FO UND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_ACPICAINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_ FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_AGPINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_CRYPTOINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_ FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_EVDEVINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_F OUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_FS9660INS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_ FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_HIDINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_HYPERVINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_ FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_PCIINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_RPCINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOU ND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_TEKENINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_F OUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_VERIEXECINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEP S_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_IPFILTERINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEP S_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_PFINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FOUN D|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_NVPAIRINS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_ FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `_MLX5INS' was not built (unmade, type OP_DEPENDS|OP_HAS_COMMANDS|OP_DEPS_FO UND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! `compat' was not built (unmade, type OP_DEPENDS|OP_PHONY|OP_HAS_COMMANDS|OP_ DEPS_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONECYCLE)! make[2]: stopped in /opt/src/git-src --- includes_subdir_lib --- make[2]: stopped in /opt/src/git-src --- includes_subdir_bin --- make[2]: stopped in /opt/src/git-src --- includes_subdir_cddl --- make[2]: stopped in /opt/src/git-src --- includes_subdir_kerberos5 --- make[2]: stopped in /opt/src/git-src --- includes_subdir_libexec --- make[2]: stopped in /opt/src/git-src make[1]: stopped in /opt/src/git-src make: stopped in /opt/src/git-src -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.