From owner-freebsd-questions@FreeBSD.ORG Sun Dec 28 23:48:03 2008 Return-Path: Delivered-To: freebsd-questions@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1C45106564A for ; Sun, 28 Dec 2008 23:48:03 +0000 (UTC) (envelope-from mich@prodnet.eu) Received: from freebsdcluster.org (freebsdcluster.dk [195.184.98.178]) by mx1.freebsd.org (Postfix) with ESMTP id 111168FC1A for ; Sun, 28 Dec 2008 23:48:03 +0000 (UTC) (envelope-from mich@prodnet.eu) Received: from [192.168.0.11] (ip-97.net-82-216-37.nice.rev.numericable.fr [82.216.37.97]) by freebsdcluster.org (Postfix) with ESMTPA id A987B28419; Sun, 28 Dec 2008 23:26:22 +0000 (UTC) References: <20081228093556.GA99170@desmo.3rdrock.kicks-ass.net> <200812280900.35582.fbsd.questions@rachie.is-a-geek.net> <20081228205720.GA18496@thought.org> Message-Id: From: Michael Landin Hostbaek To: Gary Kline In-Reply-To: <20081228205720.GA18496@thought.org> Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable X-Mailer: iPhone Mail (5G77) Mime-Version: 1.0 (iPhone Mail 5G77) Date: Mon, 29 Dec 2008 00:32:33 +0100 Cc: Michael Landin Hostbaek , Mel , "Alain G. Fabry" , "freebsd-questions@freebsd.org" Subject: Re: amarok install failure X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2008 23:48:03 -0000 On 28 d=C3=A9c. 08, at 21:57, Gary Kline wrote: > On Sun, Dec 28, 2008 at 09:00:35AM -0900, Mel wrote: >> On Sunday 28 December 2008 00:35:56 Alain G. Fabry wrote: >>> During the installation of amarok, I get the following error, what =20= >>> is going >>> wrong here. >>> >>> gmake[5]: Entering directory >>> `/usr/ports/audio/amarok/work/amarok-1.4.10/amarok/src/mediadevice/=20= >>> mtp' >>> /bin/sh /usr/local/bin/libtool --silent --tag=3DCXX --mode=3Dcompile= =20 >>> c++ >>> -DHAVE_CONFIG_H -I. -I../../../.. -I../../../../amarok/src >>> -I../../../../amarok/src -I../../../../amarok/src/amarokcore >>> -I../../../../amarok/src/amarokcore -I../../../../amarok/src/engine >>> -I../../../../amarok/src/engine -I../../../../amarok/src/mediadevice >>> -I/usr/local/include/taglib -I/usr/local/include -I/usr/local/=20 >>> include >>> -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT -I/usr/local/include >>> -I/usr/local/include -I/usr/local/include -D_GETOPT_H -=20 >>> D_THREAD_SAFE >>> -Wno-long-long -Wundef -Wall -W -Wpointer-arith -O2 -fno-strict-=20 >>> aliasing >>> -pipe -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-=20 >>> common >>> -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT >>> -DQT_NO_TRANSLATION -MT mtpmediadevice.lo -MD -MP -MF >>> .deps/mtpmediadevice.Tpo -c -o mtpmediadevice.lo mtpmediadevice.cpp >>> /usr/local/include/libmtp.h: In member function 'virtual MediaItem* >>> MtpMediaDevice::copyTrackToDevice(const MetaBundle&)': >>> /usr/local/include/libmtp.h:489: error: too many arguments to =20 >>> function 'int >>> LIBMTP_Send_Track_From_File(LIBMTP_mtpdevice_t*, const char*, >>> LIBMTP_track_t*, int (*)(uint64_t, uint64_t, const void*), const =20 >>> void*)' >>> mtpmediadevice.cpp:302: error: at this point in file >>> mtpmediadevice.cpp: In member function 'uint32_t >>> MtpMediaDevice::getDefaultParentId()': mtpmediadevice.cpp:383: =20 >>> warning: >>> deprecated conversion from string constant to 'char*' >>> /usr/local/include/libmtp.h: In member function 'LIBMTP_album_t* >>> MtpMediaDevice::getOrCreateAlbum(QPtrList*)': >>> /usr/local/include/libmtp.h:533: error: too many arguments to =20 >>> function 'int >>> LIBMTP_Create_New_Album(LIBMTP_mtpdevice_t*, LIBMTP_album_t*)' >>> mtpmediadevice.cpp:532: error: at this point in file >>> /usr/local/include/libmtp.h: In member function 'uint32_t >>> MtpMediaDevice::createFolder(const char*, uint32_t)': >>> /usr/local/include/libmtp.h:508: error: too few arguments to =20 >>> function >>> 'uint32_t LIBMTP_Create_Folder(LIBMTP_mtpdevice_t*, char*, uint32_t, >>> uint32_t)' mtpmediadevice.cpp:611: error: at this point in file >>> /usr/local/include/libmtp.h: In member function 'void >>> MtpMediaDevice::playlistFromItem(MtpMediaItem*)': >>> /usr/local/include/libmtp.h:521: error: too many arguments to =20 >>> function 'int >>> LIBMTP_Create_New_Playlist(LIBMTP_mtpdevice_t*, LIBMTP_playlist_t*)' >>> mtpmediadevice.cpp:916: error: at this point in file >>> gmake[5]: *** [mtpmediadevice.lo] Error 1 >>> gmake[5]: Leaving directory >>> `/usr/ports/audio/amarok/work/amarok-1.4.10/amarok/src/mediadevice/=20= >>> mtp' >>> gmake[4]: *** [all-recursive] Error 1 >>> gmake[4]: Leaving directory >>> `/usr/ports/audio/amarok/work/amarok-1.4.10/amarok/src/mediadevice' >>> gmake[3]: *** [all-recursive] Error 1 >>> gmake[3]: Leaving directory >>> `/usr/ports/audio/amarok/work/amarok-1.4.10/amarok/src' gmake[2]: =20= >>> *** >>> [all-recursive] Error 1 >>> gmake[2]: Leaving directory >>> `/usr/ports/audio/amarok/work/amarok-1.4.10/amarok' gmake[1]: *** >>> [all-recursive] Error 1 >>> gmake[1]: Leaving directory `/usr/ports/audio/amarok/work/=20 >>> amarok-1.4.10' >>> gmake: *** [all] Error 2 >>> *** Error code 2 >> >> This is a result of libmtp update. Either don't use libmtp, =20 >> downgrade it to >> previous version 0.2.6 or add the patch below my sig >> as /usr/ports/audio/amarok/files/patch-=20 >> amarok_src_mediadevice_mtp_mtpmediadevice.cpp >> >> --=20 >> Mel >> >> --- amarok/src/mediadevice/mtp/mtpmediadevice.cpp.orig 2008-08-13 >> 13:21:51.000000000 -0800 >> +++ amarok/src/mediadevice/mtp/mtpmediadevice.cpp 2008-12-28 >> 08:47:14.000000000 -0900 >> @@ -296,9 +296,10 @@ >> >> m_critical_mutex.lock(); >> debug() << "Sending track... " << bundle.url().path().utf8() << =20= >> endl; >> + trackmeta->parent_id =3D parent_id; >> int ret =3D LIBMTP_Send_Track_From_File( >> m_device, bundle.url().path().utf8(), trackmeta, >> - progressCallback, this, parent_id >> + progressCallback, this >> ); >> m_critical_mutex.unlock(); >> >> @@ -529,7 +530,8 @@ >> for( MtpMediaItem *it =3D dynamic_cast(items-=20= >> >first()); >> it; it =3D dynamic_cast(items->next()) ) >> album_object->tracks[i++] =3D it->track()->id(); >> album_object->no_tracks =3D items->count(); >> - ret =3D LIBMTP_Create_New_Album( m_device, album_object, 0 = ); >> + album_object->parent_id =3D 0; >> + ret =3D LIBMTP_Create_New_Album( m_device, album_object); >> if( ret !=3D 0 ) >> { >> debug() << "creating album failed : " << ret << endl; >> @@ -577,7 +579,7 @@ >> { >> if( create ) >> { >> - check_folder =3D createFolder( (*it).utf8() , =20 >> parent_id ); >> + check_folder =3D createFolder( (*it).utf8() , =20 >> parent_id); >> if( check_folder =3D=3D 0 ) >> { >> m_critical_mutex.unlock(); >> @@ -608,7 +610,9 @@ >> { >> debug() << "Creating new folder '" << name << "' as a child of =20= >> "<< >> parent_id << endl; >> char *name_copy =3D qstrdup( name ); >> - uint32_t new_folder_id =3D LIBMTP_Create_Folder( m_device, =20 >> name_copy, >> parent_id ); >> + // XXX: storage_id not used anywhere, so pass in 0, but upstream >> + // should revisit this. >> + uint32_t new_folder_id =3D LIBMTP_Create_Folder( m_device, =20 >> name_copy, >> parent_id, 0 ); >> delete(name_copy); >> debug() << "New folder ID: " << new_folder_id << endl; >> if( new_folder_id =3D=3D 0 ) >> @@ -913,7 +917,8 @@ >> if( item->playlist()->id() =3D=3D 0 ) >> { >> debug() << "creating new playlist : " << metadata->name << =20= >> endl; >> - int ret =3D LIBMTP_Create_New_Playlist( m_device, metadata, =20= >> 0 ); >> + metadata->parent_id =3D 0; >> + int ret =3D LIBMTP_Create_New_Playlist( m_device, metadata); >> if( ret =3D=3D 0 ) >> { >> item->playlist()->setId( metadata->playlist_id ); > > > Mel, > > amaroK is one of my favorites. Any idea if/how soon your > patch will be in ports? ---It's been awhile since my last > portupgrade and I'd hate to break this one, especially! I will test tomorrow, and commit straight after if it does not break =20 anything. /mich > > > gary > > >> >> _______________________________________________ >> freebsd-questions@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-questions >> To unsubscribe, send any mail to = "freebsd-questions-unsubscribe@freebsd.org=20 >> " > > --=20 > Gary Kline kline@thought.org http://www.thought.org Public =20 > Service Unix > http://jottings.thought.org http://transfinite.thought.org > The 2.17a release of Jottings: http://jottings.thought.org/=20 > index.php