From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Oct 30 23:17:48 2013 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6D6593E8; Wed, 30 Oct 2013 23:17:48 +0000 (UTC) (envelope-from nemysis@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5ABDB2BEE; Wed, 30 Oct 2013 23:17:48 +0000 (UTC) Received: from nemysis4now (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with SMTP id r9UNHjNs034515; Wed, 30 Oct 2013 23:17:46 GMT (envelope-from nemysis@FreeBSD.org) Received: by nemysis4now (sSMTP sendmail emulation); Thu, 31 Oct 2013 00:17:45 +0100 Date: Thu, 31 Oct 2013 00:17:45 +0100 From: Rusmir Dusko To: bug-followup@FreeBSD.org Subject: Re: ports/183459: [PATCH] graphics/aqsis: Fix build with OpenEXR 2.0.1 [exp-run] Message-ID: <20131030231745.GA18501@nemysis4now> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.22 (2013-10-16) Cc: freebsd-ports-bugs@FreeBSD.org, nemysis@FreeBSD.org, Pietro Cerutti X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 23:17:48 -0000 > Nemysis, > > thanks for your patch. I have a few modifications to it, in particular: > > - I don't like your change of naming convention in ${PATCHDIR}. Double > underscores are unneeded and ugly. I have used // as in this patched file. > - FLTK is not needed. It's only used in a prototype that is not included > in the build process (yet). Sure. > - I don't think installing AUTHORS and README is of much use. I think that users wish this, but what you wish. > Moreover, can you please elaborate on using shared-mime-info? I'm not > familiar with that, and I've got this warnings on port test: > > ===> Extra files and directories check > share/mime/subclasses > share/mime/globs > share/mime/globs2 > share/mime/magic > share/mime/XMLnamespaces > share/mime/aliases > share/mime/types > share/mime/generic-icons > share/mime/icons > share/mime/treemagic > share/mime/mime.cache > share/mime/version > > Is this going to be a problem? No these lefover are mtree and is normal. > A new diff is attached. I accept this diff and soon commit with all other Ports which need bump port revision after exp-run for graphics/ilmbase and grahics/OpenEXR update to 2.0.1.